Skip to content

Commit 3689991

Browse files
os-steveclaude
andauthored
fix(qa): correct rootDir comment that opens "No rootDir" above one that sets it (#11919)
git history (full clone): the file was created (#3349) with `"rootDir": "."` and no comment. The very same commit that later broadened it to `"rootDir": "../../.."` (#7526/#7584) also introduced the seven-line comment whose opening sentence claims there is none — the contradiction was there from the moment the comment was written, not a later drift. `git log -S'rootDir'` on this path finds only those two commits; no earlier form of the file ever had a bare "no rootDir" state, so disposition is a one-sentence wording fix, not a removal. Verified the comment's own argument still holds: the only file in the package importing outside it (route-ledger-live-mount-parity.dogfood.test.ts) resolves all five of its relative imports under `../../..`, so the declared rootDir still never constrains anything. `tsc --showConfig` is byte-identical before/after (comments are stripped before parsing) — no behaviour change. Scope: this one file's comment text only, per #10899's standing fence. Fixes #11476 Claude-Session: https://claude.ai/code/session_015ahemw8RcTgqtxrj15PEZx Co-authored-by: Claude <noreply@anthropic.com>
1 parent ce744bc commit 3689991

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

packages/qa/dogfood/tsconfig.json

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@
88
"skipLibCheck": true,
99
"noEmit": true,
1010
"types": ["node"],
11-
// No `rootDir`. This project emits nothing (`noEmit`), so `rootDir` never
12-
// shaped an output layout here — its only effect was to forbid importing a
13-
// sibling package's SOURCE file, and the route-ledger ↔ live-mount parity
14-
// gate (#7526) must read the five ledgers exactly that way: each one is
15-
// package-internal on purpose (the guard's data, not public API), so there
16-
// is no entry point to import them from. Every other ledger guard in the
17-
// repo compiles them as relative sources for the same reason.
11+
// `rootDir` is set to the repo root — wide enough to be a no-op. This
12+
// project emits nothing (`noEmit`), so `rootDir` never shaped an output
13+
// layout here — its only effect was to forbid importing a sibling
14+
// package's SOURCE file, and the route-ledger ↔ live-mount parity gate
15+
// (#7526) must read the five ledgers exactly that way: each one is
16+
// package-internal on purpose (the guard's data, not public API), so
17+
// there is no entry point to import them from. Every other ledger guard
18+
// in the repo compiles them as relative sources for the same reason.
1819
"rootDir": "../../.."
1920
},
2021
"include": ["test/**/*"],

0 commit comments

Comments
 (0)