Skip to content

Commit 44918e3

Browse files
committed
test(service-analytics): record the measured ablation direction
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ToDPcx9AESFubJkDiFMtKW
1 parent 7200f32 commit 44918e3

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

packages/services/service-analytics/src/__tests__/dataset-reference-dimension-labels.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@
5454
*
5555
* Ordinary direction, no inversion and no count movement: the change ADDS
5656
* resolutions that were absent and narrows no rule, so restoring the two-member
57-
* subset must turn RED exactly the cases whose dimension is `user` / `tree` /
58-
* `master_detail`, and leave GREEN every `lookup`, `select`, unresolved-id,
59-
* no-display-field and fail-closed case — those pin behaviour this change
60-
* converges ON. The measured run is quoted in the PR body.
57+
* subset must turn RED exactly the cases that depend on a `user` or `tree` axis,
58+
* and leave GREEN every `lookup`, `master_detail`, `select`, unresolved-id,
59+
* no-display-field and fail-closed case — `master_detail` was already inside the
60+
* old subset, so it is a control here, not a casualty. Predicted on that reading:
61+
* 7 red in this file and 3 in the `dimension-labels` sibling. Measured exactly
62+
* that (10 red / 33 green over the two files); the run is quoted in the PR body.
6163
*/
6264

6365
import { describe, it, expect } from 'vitest';

0 commit comments

Comments
 (0)