wip(spec): migrate the two object-* fixtures in component.test.ts; ask each key at its own door in the binding pins

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH

Author: claude

packages/spec/src/ui/component.test.ts

@@ -2653,12 +2653,16 @@ describe('#7751 — object-* block props schemas', () => {
   });
 
   it('the corrected #7750 node (my-work.page.ts, post-fix) parses GREEN and retains its filter', () => {
+    // The node as the showcase authors it since #15442 / #15449: the
+    // `ViewFilterRule` array (ui#6206-B). The AST tuple this pin carried
+    // before is refused at `filter.0` now — pinned in the object-* filter
+    // describe below.
     const parsed = ComponentPropsMap['object-grid'].parse({
       objectName: 'showcase_task',
       columns: ['title', 'project', 'status', 'priority', 'due_date'],
-      filter: [['owner_id', '=', '{current_user_id}']],
+      filter: [{ field: 'owner_id', operator: 'equals', value: '{current_user_id}' }],
     });
-    expect(parsed.filter).toEqual([['owner_id', '=', '{current_user_id}']]);
+    expect(parsed.filter).toEqual([{ field: 'owner_id', operator: 'equals', value: '{current_user_id}' }]);
   });
 
   it("object-grid `data` takes the ViewDataSchema provider object — the ui#6207 convergence (Option A)", () => {
@@ -2733,10 +2737,13 @@ describe('#7751 — object-* block props schemas', () => {
   it('every object-metric node of the showcase corpus parses GREEN (the clean-corpus control)', () => {
     // Copies of all three my-work.page.ts metrics + the command-center shape
     // (variant/format) — the exact nodes the lint must NOT start warning on.
+    // The three filters are the `ViewFilterRule` arrays the showcase authors
+    // since #15442 / #15449 (ui#6206-B); the records they replaced are refused
+    // at `filter` now (pinned in the object-* filter describe above).
     const nodes = [
-      { objectName: 'showcase_task', label: 'Open Tasks', icon: 'list-checks', colorVariant: 'blue', description: 'not done', aggregate: { field: 'id', function: 'count' }, filter: { status: { $ne: 'done' } } },
-      { objectName: 'showcase_task', label: 'In Review', icon: 'eye', colorVariant: 'warning', description: 'awaiting review', aggregate: { field: 'id', function: 'count' }, filter: { status: 'in_review' } },
-      { objectName: 'showcase_project', label: 'At-Risk Projects', icon: 'alert-triangle', colorVariant: 'danger', description: 'health red', aggregate: { field: 'id', function: 'count' }, filter: { health: 'red' } },
+      { objectName: 'showcase_task', label: 'Open Tasks', icon: 'list-checks', colorVariant: 'blue', description: 'not done', aggregate: { field: 'id', function: 'count' }, filter: [{ field: 'status', operator: 'not_equals', value: 'done' }] },
+      { objectName: 'showcase_task', label: 'In Review', icon: 'eye', colorVariant: 'warning', description: 'awaiting review', aggregate: { field: 'id', function: 'count' }, filter: [{ field: 'status', operator: 'equals', value: 'in_review' }] },
+      { objectName: 'showcase_project', label: 'At-Risk Projects', icon: 'alert-triangle', colorVariant: 'danger', description: 'health red', aggregate: { field: 'id', function: 'count' }, filter: [{ field: 'health', operator: 'equals', value: 'red' }] },
       { objectName: 'showcase_task', label: 'Tasks', colorVariant: 'purple', variant: 'bare', aggregate: { field: 'id', function: 'count' }, format: '0,0' },
     ];
     for (const node of nodes) {

packages/spec/src/ui/page.test.ts

@@ -15,6 +15,7 @@ import {
   type ElementDataSource,
   type InterfacePageConfig,
 } from './page.zod';
+import { ComponentPropsMap } from './component.zod';
 
 describe('PageComponentSchema', () => {
   it('should accept valid minimal component', () => {
@@ -666,6 +667,9 @@ describe('ElementDataSourceSchema `filter` — one filter orthography platform-w
   /** The issues a parse raised under `key` (top-level), whatever else it raised. */
   const issuesUnder = (r: ParseResult, key: string) =>
     r.success ? [] : r.error!.issues.filter((i) => i.path[0] === key);
+  /** The issues located EXACTLY at `path` (dotted) — `filter` is not `filter.0`. */
+  const issuesAt = (r: ParseResult, path: string) =>
+    r.success ? [] : r.error!.issues.filter((i) => i.path.join('.') === path);
 
   it('accepts a ViewFilterRule[] filter — the acceptance criterion', () => {
     // Before #15442 this exact value was REFUSED here (`invalid_type`, expected
@@ -727,34 +731,36 @@ describe('ElementDataSourceSchema `filter` — one filter orthography platform-w
     // seventeen off-spec authors at the pin are the seat's objectui follow-up.
     const r = ElementDataSourceSchema.safeParse({ object: 'account', filter: TUPLE_ARRAY });
     expect(r.success).toBe(false);
-    expect(issuesUnder(r, 'filter')).toEqual([]);
-    const atElement = r.error!.issues.filter((i) => i.path.join('.') === 'filter.0');
-    expect(atElement.map((i) => i.code)).toEqual(['invalid_type']);
+    expect(issuesAt(r, 'filter')).toEqual([]);
+    expect(issuesAt(r, 'filter.0').map((i) => i.code)).toEqual(['invalid_type']);
+    expect(issuesAt(r, 'filter.0')[0]).toMatchObject({ expected: 'object' });
   });
 
   it('shares the array orthography with the props-map `filter` doors — one value, two keys, the same verdicts', () => {
     // `element:record_picker` was the node that carried two orthographies at
     // two keys (`properties.filter` the array, `dataSource.filter` the record)
-    // resolved through one `??` in the renderer. The same rule array now raises
-    // no issue at either key, and the same record is refused at both with the
-    // same code — measured through the real `PageComponentSchema`, the door an
-    // authored page actually passes.
-    const both = PageComponentSchema.safeParse({
+    // resolved through one `??` in the renderer. Each key is asked at ITS
+    // door: the binding through the real `PageComponentSchema` (which parses
+    // `dataSource` and leaves `properties` a bag — the props-map dispatch is
+    // the lint's, warning tier), and the props key through the picker's own
+    // `ComponentPropsMap` entry. The same rule array raises no issue at either;
+    // the same record is refused at both with the same code.
+    const binding = PageComponentSchema.safeParse({
       type: 'element:record_picker',
       properties: { object: 'account', filter: RULES },
       dataSource: { object: 'account', filter: RULES },
     });
-    expect(both.success).toBe(true);
-    const bothRecords = PageComponentSchema.safeParse({
+    expect(binding.success).toBe(true);
+    const bindingRecord = PageComponentSchema.safeParse({
       type: 'element:record_picker',
-      properties: { object: 'account', filter: RECORD_FORM },
+      properties: { object: 'account', filter: RULES },
       dataSource: { object: 'account', filter: RECORD_FORM },
     });
-    expect(bothRecords.success).toBe(false);
-    const codesAt = (path: string) =>
-      bothRecords.error!.issues.filter((i) => i.path.join('.') === path).map((i) => i.code);
-    expect(codesAt('dataSource.filter')).toEqual(['invalid_type']);
-    expect(codesAt('properties.filter')).toEqual(codesAt('dataSource.filter'));
+    expect(issuesAt(bindingRecord, 'dataSource.filter').map((i) => i.code)).toEqual(['invalid_type']);
+    const picker = ComponentPropsMap['element:record_picker'];
+    expect(issuesAt(picker.safeParse({ object: 'account', filter: RULES }), 'filter')).toEqual([]);
+    expect(issuesAt(picker.safeParse({ object: 'account', filter: RECORD_FORM }), 'filter').map((i) => i.code))
+      .toEqual(issuesAt(bindingRecord, 'dataSource.filter').map((i) => i.code));
   });
 });