Commit 7d483e1
`archiveObject` read `archive.after` — and, since #10347, `ttl.expireAfter` —
straight off the declaration, so for any object declaring `lifecycle.archive`
an operator's settings override was silently ignored, a registered
`LifecycleRetentionFloor` was never evaluated, and per-tenant windows did not
apply.
The cause is structural, not a forgotten call: `reapObject` returns into
`archiveObject` when `archive` is declared, so the three `effectiveWindowMs`
resolutions on the reap path sit on a branch archive-declaring objects skip
entirely. Governance is therefore resolved inside `archiveObject`, where the
#10347 ruling already put the decision about WHICH window is due — resolving it
in the caller would duplicate that selection or split one decision across two
methods, and the per-tenant leg is a pass over this method's own batch loop
either way.
All three legs now run through the same resolver the Reaper uses: the global
override (on the key matching the selected window), the retention floor
(#5195) for both overrides and declarations, and per-tenant windows as one
candidate read per overriding tenant plus a global pass covering NULL-org rows.
#10347's cutoff selection, the retain-first posture, the per-batch abort checks
and the cold-side `archive.keep` prune are unchanged.
Claude-Session: https://claude.ai/code/session_019yDEhPBC3tcGkW9bkce1HM
Co-authored-by: Claude <noreply@anthropic.com>
1 parent cfb8ae4 commit 7d483e1
3 files changed
Lines changed: 680 additions & 53 deletions
File tree
- .changeset
- packages/objectql/src/lifecycle
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
0 commit comments