Skip to content

Commit 8227a19

Browse files
claude[bot]claude
andauthored
fix(release): cut-rc.yml's hotcrm smoke warning no longer claims pre-exit re-arms the gate (#14610)
The step's warning string and its comment both keyed the gate's re-arm event to `changeset pre exit`, which release.yml's own comment records was superseded (#8643): pre-exit fired and the deadlock stood anyway, because a migrated hotcrm release did not exist yet. release.yml's gate now keys the same posture on shipping a migrated hotcrm release and bumping HOTCRM_REF (+ BLOCKING=1), and its warning already says so. This mirrors that wording into cut-rc.yml's warning and drops the "#3600 amendment" keying from the step comment in favor of the actual reason this lane's step is advisory: it has no BLOCKING switch and only ever runs in pre mode. No logic change — if:/env:/run: control flow and HOTCRM_REF are untouched, and release.yml is untouched. Co-authored-by: Claude <noreply@anthropic.com>
1 parent 13bf05d commit 8227a19

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/cut-rc.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -866,11 +866,11 @@ jobs:
866866
echo "@objectstack/cli@$(jq -r '.version' packages/cli/package.json) is on main at ${LOCAL}."
867867
868868
# Pre-publish gate #2035, kept in step with release.yml's publish job rather
869-
# than dropped for speed. In pre mode (which the guard step proved is active,
870-
# so ALWAYS on this lane) the #3600 amendment makes it advisory: a major
871-
# train exists to ship deliberate surface removals, and a migrated hotcrm
872-
# cannot exist until the rc artifacts it would migrate against are published.
873-
# It reports; it cannot block.
869+
# than dropped for speed. This step is advisory by construction — it has no
870+
# BLOCKING switch — because this lane only ever runs in pre mode (the guard
871+
# step above proved it active). It reports; it cannot block. For why the
872+
# equivalent gate in release.yml is currently advisory too, and what re-arms
873+
# it, see that step's own comment.
874874
- name: Downstream backward-compat smoke (live hotcrm, advisory in pre mode)
875875
if: ${{ !inputs.dry_run }}
876876
env:
@@ -879,7 +879,7 @@ jobs:
879879
if bash scripts/downstream-smoke.sh; then
880880
echo "::notice::hotcrm@${HOTCRM_REF} is still compatible with the pre-release train."
881881
else
882-
echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release and bump HOTCRM_REF in release.yml before 'changeset pre exit' re-arms that gate."
882+
echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release, bump it, and set BLOCKING=1 in .github/workflows/release.yml to re-arm this gate."
883883
fi
884884
885885
# ────────────────────────────────────────────────────────────────────────

0 commit comments

Comments
 (0)