Commit a3bbb8b
fix(devx): an artifact-roster row either judges the diff or says plainly that it cannot (#16221)
* wip: roster checker-health split, reason ordering, docblock clause
* fix(devx): an artifact-roster row either judges the diff or says plainly that it cannot
The `--commands` roster block tells its reader to run its rows, and for some of
them running them yields a green that cannot fail for anything in the diff: the
invocation resolves to the checker's own `--self-test` and nothing else. Those
rows sat in the same list, in the same syntax, as rows whose green does grade
the diff.
The two named rows are self-test-only ON PURPOSE -- the half of each gate that
judges a pull request needs the event payload and runs in its own workflow -- so
the repair is to say so, not to change the script definitions. Rows are now
split by a derived predicate, with the marker on the row rather than only in a
caption, because consumers of this block grep rows.
The discriminator is resolved one hop through the manifest that DEFINES the
name: reading the printed command alone selects five rows and misses both rows
this is about, since a pnpm-spelled row carries the flag in its manifest entry.
An invocation this tool cannot resolve is named unclassified rather than
defaulted into either side.
Rider: the residue printer now names the refusal that actually fired for a bare
separator-less literal, by ordering that branch ahead of the extensionless-target
branch, with the refusal itself given one owner that `hintCovers` calls.
Reachability re-measured: 236 dead hints, 0 reaching the target branch.
Rider: one docblock clause in check-cross-package-test-inputs completes the
single-segment refusal's statement of the rule with its one exception.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vbw3RPgdtqesx4azk9SbW8
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 212eaba commit a3bbb8b
2 files changed
Lines changed: 360 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
352 | 352 | | |
353 | 353 | | |
354 | 354 | | |
355 | | - | |
356 | | - | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
357 | 362 | | |
358 | 363 | | |
359 | 364 | | |
| |||
0 commit comments