Commit aaff32c
committed
docs(client): README approval decisions are objects, and register carries its required name
The published README's namespace tour called `approvals.approve` / `approvals.reject`
with a bare comment string. Both declare
`(requestId: string, decision?: { actorId?; comment?; attachments? })`, so a TypeScript
reader gets TS2559 and a JavaScript reader gets nothing at all — the string goes out as
the request body where the route reads the decision object's fields, and the approval's
reason is silently dropped.
Type-checking the whole fence against the package's own built `dist/index.d.ts` turned up
one more call in the same defect class: `auth.register` was passed `{ email, password }`
while `RegisterRequestSchema` declares `name` as required, failing TS2345.
All three now match the spelling `content/docs/api/client-sdk.mdx` already carries. No
source changes; `packages/client/src/index.ts` was read only.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015QE8qk46e5CHJxyQEUjbf81 parent ed6579b commit aaff32c
2 files changed
Lines changed: 14 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
| 240 | + | |
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| |||
252 | 252 | | |
253 | 253 | | |
254 | 254 | | |
255 | | - | |
256 | | - | |
| 255 | + | |
| 256 | + | |
257 | 257 | | |
258 | 258 | | |
259 | 259 | | |
| |||
0 commit comments