Skip to content

Commit ad7dcbc

Browse files
committed
fix(spec): scope the at-rest stored-pass clause to this shape, not to protocol 18
`conversionIds` on step 18 is NOT empty — it carries the major's other D2 conversions — so "nothing to rewrite here" could be read as "the stored pass rewrites nothing at protocol 18", which is false. The true scope is this entry's disposition, which adds no D2 conversion of its own (its id is 0x in `conversions/registry.ts`, control `action-execute-to-target` lit at 1x). `registry.ts` follows by `gen:migration-registry`. Claude-Session: https://claude.ai/code/session_01MkQhmuuJAVDjmeWNixwDDH Co-authored-by: Claude <noreply@anthropic.com>
1 parent 816f181 commit ad7dcbc

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/spec/src/migrations/entries/semantic/18.element-data-source-and-object-block-filter-rule-array.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ export const entry: SemanticMigration = {
6060
+ '⚠️ Metadata AT REST is deliberately NOT rewritten, and this disposition adds no D2 '
6161
+ 'conversion — a SemanticMigration converts nothing by its own type, and '
6262
+ '`os migrate meta --stored` (the pass over a deployment\'s `sys_metadata` rows) replays '
63-
+ 'D2 conversions only, so it has nothing to rewrite here. The read path does not '
64-
+ 're-validate stored rows '
63+
+ 'D2 conversions only, so it has nothing to rewrite for this shape. The read path '
64+
+ 'does not re-validate stored rows '
6565
+ '(`applyConversionsToStoredItem` replays the full chain without validating, by its own '
6666
+ 'contract), so a stored page or block carrying the record form keeps loading unchanged '
6767
+ 'and is still rendered by objectui at the pinned `.objectui-sha`; what changes is that '

packages/spec/src/migrations/registry.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6951,8 +6951,8 @@ const step18: MigrationStep = {
69516951
+ '⚠️ Metadata AT REST is deliberately NOT rewritten, and this disposition adds no D2 '
69526952
+ 'conversion — a SemanticMigration converts nothing by its own type, and '
69536953
+ '`os migrate meta --stored` (the pass over a deployment\'s `sys_metadata` rows) replays '
6954-
+ 'D2 conversions only, so it has nothing to rewrite here. The read path does not '
6955-
+ 're-validate stored rows '
6954+
+ 'D2 conversions only, so it has nothing to rewrite for this shape. The read path '
6955+
+ 'does not re-validate stored rows '
69566956
+ '(`applyConversionsToStoredItem` replays the full chain without validating, by its own '
69576957
+ 'contract), so a stored page or block carrying the record form keeps loading unchanged '
69586958
+ 'and is still rendered by objectui at the pinned `.objectui-sha`; what changes is that '

0 commit comments

Comments
 (0)