Skip to content

Commit b03d01e

Browse files
claude[bot]claude
andauthored
docs(pm): drop the stale shadowing claim from dispatch-gates' selfTest comment (#15345)
PR #14988 replaced the five named `node:path` imports with one namespace binding (`import * as nodePath`), so no module-scope `relative` binding exists for the fixture string to shadow. Restate the standing reason the repo-relative spelling comes from ROOT: it is the prefix every sibling case in the block already joins against, not a workaround. Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox Co-authored-by: Claude <noreply@anthropic.com>
1 parent 638ea04 commit b03d01e

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

scripts/pm/dispatch-gates.mjs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17888,11 +17888,10 @@ function selfTest() {
1788817888
}
1788917889
return { sites, perRoot };
1789017890
};
17891-
// `relative` from `node:path` is SHADOWED inside this function — a fixture
17892-
// string a few thousand lines up binds that name — so the repo-relative
17893-
// spelling comes from ROOT, the prefix every sibling case here already joins
17894-
// against. A prefix that stops holding yields an empty root, which the walk
17895-
// above reports rather than turning into a pass.
17891+
// The repo-relative spelling here comes from ROOT, the prefix every sibling
17892+
// case in this block already joins against — the consistent spelling, not a
17893+
// workaround. A prefix that stops holding yields an empty root, which the
17894+
// walk above reports rather than turning into a pass.
1789617895
const tierOwnAbs = fileURLToPath(import.meta.url);
1789717896
const tierOwnRel = tierOwnAbs.startsWith(ROOT) ? tierOwnAbs.slice(ROOT.length) : '';
1789817897
// The definition line is FOUND, not remembered: the one line carrying both

0 commit comments

Comments
 (0)