Commit b0ce3f7
chore(cli): retire SCAFFOLD_TSX_RANGE, a conditional statement nothing satisfies (#16951)
The `os create example` template was the only emission that ever declared a
`tsx` range; once it was retired the constant reached no scaffold at all.
Its docblock -- "The `tsx` range a scaffolded project declares when its scripts
need it" -- is not a false statement but a conditional whose antecedent nothing
on the tree satisfies. Vacuously true, so a review hunting false statements
never catches it; what it misleads is the reader's default assumption that some
scaffold satisfies the antecedent. The constant and its docblock are removed
together.
No surviving emission should declare `tsx`: all four (`os init -t app` /
`-t plugin` / `-t empty`, `os create plugin`) plus the bundled
`create-objectstack` blank template run every script they emit through
`objectstack`, `tsc` or `vitest`, none of which executes a `.ts` entrypoint
directly. `@objectstack/cli`, which each of them declares, already carries `tsx`
as its own dependency.
No assertion is added for the retired range. The comment in
`test/scaffold-emission-policy.e2e.test.ts` is updated to describe the
retirement rather than the intermediate state, keeping its rule intact: a row is
owed by a range some emission really declares, and by nothing else.
Claude-Session: https://claude.ai/code/session_015QE8qk46e5CHJxyQEUjbf8
Co-authored-by: Claude <noreply@anthropic.com>1 parent f36eef5 commit b0ce3f7
3 files changed
Lines changed: 46 additions & 7 deletions
File tree
- .changeset
- packages/cli
- src/commands
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
317 | 317 | | |
318 | 318 | | |
319 | 319 | | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | 320 | | |
324 | 321 | | |
325 | 322 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
211 | 215 | | |
212 | 216 | | |
213 | 217 | | |
| |||
0 commit comments