Repository navigation
Commit b4b83b3
fix(cloud-connection,spec): cite the cloud control-plane decisions as
Fixes #18762
Clause-②: no
Prime Directive 13 requires a cloud decision to be cited as `cloud
ADR-NNNN`, "never as a bare number, which
`scripts/check-adr-anchors.mjs` resolves against *this* registry (the
two number independently)". The rule landed; the stock already in the
tree was never swept. This sweeps it, on the file surface the dispatch
named.
19 citations gain the `cloud` qualifier. No behaviour, type, export,
route or schema moves — citation spelling and prose only.
## The spelling, taken from the precedent
The same-shape card the issue names is #18685, landed in PR #18754. Its
changeset states the convention verbatim:
> AGENTS.md Prime Directive 13 is explicit — an ADR "lives in the
repository whose code it governs", and a cloud decision is cited as
`cloud ADR-NNNN`, "never as a bare number".
Mechanically, that PR inserted the qualifier adjacent to the id and
changed nothing else around it: `(cloud, post-ADR-0025)` became `(cloud,
post-cloud ADR-0025)`. This PR does the same — a bare `cloud` token
immediately before the number, on the same line, surrounding prose
byte-identical.
That form is also the only one the gate recognises.
`scripts/check-adr-anchors.mjs` parses `ADR_CITATION =
/(?:([A-Za-z0-9_./-]+)[ \t]+)?ADR-(\d{4})/g` and exempts only
`CROSS_REPO_QUALIFIERS = new Set(['objectui', 'object-ui', 'cloud'])`,
so the qualifier must be the token immediately before the id with only
spaces or tabs between. Card #18761, which measured that the exemption
face is narrower than this repo's prose habits, is open and is not
addressed here — this PR deliberately stays inside the recognised form
rather than adding to the set it reports on.
## Site one — bare `ADR-0008` in `@objectstack/cloud-connection`
The card grades this one 「成色强」.
Re-derived on `origin/main` = `07c6f822ed` with the gate's own parser,
printed per line rather than counted — 10 files name `ADR-0008`, in 17
citation rows:
| spelling | rows |
|---|---|
| already `cloud ADR-0008` | `CHANGELOG.md:5229` ·
`src/cloud-connection-ui.ts:8` · `src/connection-credential-store.ts:5`
· `src/connection-credential-store.test.ts:5` |
| bare | `CHANGELOG.md:5228` · `README.md:3` · `README.md:189` ·
`package.json:5` · `src/cloud-connection-plugin.test.ts:4` ·
`src/cloud-connection-plugin.ts:5,21,24,54` ·
`src/cloud-connection-route-ledger.ts:103,128` · `src/index.ts:5,77` |
So the defect surface is narrower than the file count suggests: 12 bare
rows in 7 files, of which 11 rows in 6 files are fixed here and one is
excluded below. Three of the ten files already used the compliant
spelling.
Bare `ADR-0008` resolves, in this repository, to
`docs/adr/0008-metadata-repository-and-change-log.md` — *Metadata
Repository, Change Log & Subscription (M0 → M4)*. Grepped in that record
and printed: zero lines matching `control plane`, zero matching
`cloud-connection`, zero matching `Phase 1` or `Phase 2`; the lit
control `change log` returns lines, so the instrument is alive and those
three zeros are real.
`README.md:189` is the row the card starred: it said "in the cloud
repository" and wrote the number bare in the same sentence. It now reads
```
See `docs/adr` in the cloud repository (cloud ADR-0008) for the full architecture
decision.
```
## Site two — bare `ADR-0003` in `platform-object-names.test.ts`
The card grades this one 「成色弱一些」, and kept its own dev's wording off the
record for overstating it. **This PR keeps the two gradings apart and
does not assert one confidence for both.**
Exactly one row, re-derived:
`packages/spec/src/system/constants/platform-object-names.test.ts:132`,
`// They live in @objectstack/service-tenant (cloud repo, ADR-0003). If
one`. The parenthetical names the cloud repo and writes the number bare,
the same shape as the precedent card.
What was re-measured in
`docs/adr/0003-package-as-first-class-citizen.md`, printed:
- title *Package as First-Class Citizen with Versioned Releases*;
- `platform object` — zero lines;
- `service-tenant` — three lines (7, 193, 194), so it is **not**
unrelated, and the card's own downgrade holds. Line 194 is the
load-bearing one: it records that `packages/services/service-tenant/`
**left this repository** for `objectstack-ai/cloud` in `473fce590`;
- lit control `package` returns many lines.
So the local record is real and adjacent, and still is not the decision
the comment cites. The line is now `(cloud repo, cloud ADR-0003)` —
minimal insertion, per the precedent, rather than a prose rewrite.
cloud ADR-NNNN, not bare numbers that resolve to this repo's own records (#19119)1 parent 14a762f commit b4b83b3
10 files changed
Lines changed: 70 additions & 19 deletions
File tree
- .changeset
- packages
- cloud-connection
- src
- spec/src/system/constants
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
190 | 190 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
| 54 | + | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| |||
588 | 588 | | |
589 | 589 | | |
590 | 590 | | |
591 | | - | |
| 591 | + | |
592 | 592 | | |
593 | 593 | | |
594 | 594 | | |
| |||
628 | 628 | | |
629 | 629 | | |
630 | 630 | | |
631 | | - | |
| 631 | + | |
632 | 632 | | |
633 | 633 | | |
634 | 634 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | | - | |
| 103 | + | |
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
| 77 | + | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
132 | | - | |
| 132 | + | |
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
| |||
0 commit comments