Commit b922105
committed
fix(spec): the changeset still asserted what round 4 retracted — and three wordings overstated
Round 4 touched four files and not the changeset, so the tree carried both the
retracted claim and the corrected one at once. The changeset is the published
CHANGELOG entry for @objectstack/spec, an author-facing surface, which makes
that round 2's lesson repeated inside the tree instead of in the PR body.
1. Changeset 'What the published text said' rewritten to the round-4 claim:
'only when unset' is exactly right for this face; the accept set is a
SUBSET of isUsableRowLimit so 'set but not usable' is empty; the view half
is pagination.pageSize ALONE, with savedViewLimit's flat view.limit named
as the saved-view RECORD face it belongs to. Grade unchanged at patch --
this is text, not level.
2. 'the SAME set this key declares' overstated and is now the derivable
claim, accept-set SUBSET-OF usable-set, with the separating witness:
2**53+2 is refused here (zod 4 .int() is safe-integer, too_big) and
Number.isInteger calls it usable. Verified by parse, not asserted.
The test title moves the same way and the witness is pinned as a case.
3. The test comment claimed 'either side widening reds this'. Half wrong, and
now stated asymmetrically: the SPEC side reds (nullable, a 0 sentinel,
dropping .int(), adding a .default() each fail a specific expect), but the
GATE side CANNOT -- usableToTheGate is a transcription of isUsableRowLimit
dated to pin 87af769e9, not an import, so a rewrite at objectui HEAD leaves
this green. It refreshes only on a pin bump, by hand.
4. The instrument partition was off by one label: ListView.kanbanOptionsBag
Canonical-8193.test.tsx:99 is an it() title string, not a comment. Now 2
comments, 1 test-title string, 2 quoted-pin lines -> 8 executable of 13.
The spread predicate's exclusion list also gains ListView.tsx:3044-3046
(mergedGallery, nested) and app-shell ObjectView.tsx:1284 (a write back
into a view document's own block, not a node build).
No describe changed, so no .mdx regenerates; check:generated is green without
--fix, which is the prediction this round was able to state in advance.
Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx1 parent 01a7ce4 commit b922105
4 files changed
Lines changed: 70 additions & 27 deletions
File tree
- .changeset
- packages/spec/src/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
24 | 35 | | |
25 | 36 | | |
26 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3857 | 3857 | | |
3858 | 3858 | | |
3859 | 3859 | | |
3860 | | - | |
| 3860 | + | |
3861 | 3861 | | |
3862 | 3862 | | |
3863 | 3863 | | |
3864 | 3864 | | |
3865 | | - | |
3866 | | - | |
3867 | | - | |
3868 | | - | |
3869 | | - | |
| 3865 | + | |
| 3866 | + | |
| 3867 | + | |
| 3868 | + | |
| 3869 | + | |
| 3870 | + | |
| 3871 | + | |
| 3872 | + | |
| 3873 | + | |
| 3874 | + | |
| 3875 | + | |
| 3876 | + | |
| 3877 | + | |
| 3878 | + | |
| 3879 | + | |
3870 | 3880 | | |
3871 | 3881 | | |
3872 | 3882 | | |
| |||
3884 | 3894 | | |
3885 | 3895 | | |
3886 | 3896 | | |
| 3897 | + | |
| 3898 | + | |
| 3899 | + | |
| 3900 | + | |
| 3901 | + | |
| 3902 | + | |
| 3903 | + | |
| 3904 | + | |
| 3905 | + | |
3887 | 3906 | | |
3888 | 3907 | | |
3889 | 3908 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3104 | 3104 | | |
3105 | 3105 | | |
3106 | 3106 | | |
3107 | | - | |
3108 | | - | |
3109 | | - | |
3110 | | - | |
| 3107 | + | |
| 3108 | + | |
| 3109 | + | |
| 3110 | + | |
| 3111 | + | |
| 3112 | + | |
| 3113 | + | |
| 3114 | + | |
3111 | 3115 | | |
3112 | 3116 | | |
3113 | 3117 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1248 | 1248 | | |
1249 | 1249 | | |
1250 | 1250 | | |
1251 | | - | |
1252 | | - | |
1253 | | - | |
1254 | | - | |
| 1251 | + | |
| 1252 | + | |
| 1253 | + | |
| 1254 | + | |
| 1255 | + | |
| 1256 | + | |
| 1257 | + | |
| 1258 | + | |
1255 | 1259 | | |
1256 | 1260 | | |
1257 | 1261 | | |
| |||
1266 | 1270 | | |
1267 | 1271 | | |
1268 | 1272 | | |
1269 | | - | |
| 1273 | + | |
| 1274 | + | |
| 1275 | + | |
| 1276 | + | |
| 1277 | + | |
| 1278 | + | |
1270 | 1279 | | |
1271 | 1280 | | |
1272 | 1281 | | |
| |||
0 commit comments