Commit bf70dbf
committed
docs(runtime): correct three untrue claims this branch wrote down
Round 2 on #15890, after review. Comment prose only — no executable line
moves, the pin and its ablation are untouched and settled.
1. HISTORY. The previous commit on this branch wrote, of
`ListRunsRequestSchema`, in `domains/automation.ts`:
"has always declared it — as `ExecutionStatus.optional()`, the enum
itself rather than a copy of its members"
and in `query-param.ts`:
"bounds it to `ExecutionStatus` itself — the enum, never a copy of its
members"
Both are FALSE of history, and — the whole lesson — the sentence the
first one replaced was accurate. `ListRunsRequestSchema` declared
`status` as an inline
`z.enum(['pending', 'running', 'paused', 'completed', 'failed',
'cancelled', 'timed_out', 'retrying']).optional()` from the schema's
introduction (`5e685a7d6f7`, 2026-02-21) until #7359 replaced that copy
with `ExecutionStatus.optional()` — landed as `cf7c69421a7`
(2026-08-11), in the same commit that made this boundary read the
parameter. So "always" and "never" are both wrong: it was a copy of
eight members for most of its life.
Verified by `git show 5e685a7:packages/spec/src/api/automation-api.zod.ts`,
`git show cf7c694^:` on the same path, and `git log -S` on that
literal — which names exactly two commits, the introduction and #7359.
Repairing the stale COUNT had introduced a falsehood about HISTORY, in
a card whose entire subject is untrue claims about this vocabulary.
Both sites now say what the line declares today AND when it started
saying it. No count of the LIVE enum is minted; "eight" is a property
of a deleted literal, frozen by `cf7c69421a7`, and it is what makes the
sentence explain itself.
2. `TERMINAL_RUN_STATUSES`. The previous commit called it
"a documented narrower subset"
Measured in `plugin-approvals/src/approval-service.ts`, it is
`{completed, failed, cancelled, timed_out}` — a set its own header
calls "A CLOSED set, deliberately", whose dead-run sweep treats every
other answer, an unknown status included, as ALIVE so an unrecognised
state can never cost someone a live approval. That is a fail-safe
default, not a narrowing anyone documented relative to `ExecutionStatus`.
It was closed before `refused` existed, and `refused` — "Terminal,
never resumed" — is not in it, so once lane 2 (#15788) makes a run
reach that status, its still-pending approval reads as alive to that
sweep. A reader of this vocabulary that has not learned the new member,
owned by the `refused` lanes, not by this card. Corrected in the PR
body; no tree text carried the wrong wording.
3. "#16414 landed hours ago" (previous commit and PR body). #16414 landed
`0ea5f9d9f79` at 2026-09-06T21:22:02Z; the commit that said "hours" was
authored 22:50:48Z the same day — 89 minutes by those two stamps, 66 by
the review's anchor. Two anchors, two numbers, and the elapsed time was
never load-bearing: the citation of #16414 stays, the time reference is
dropped rather than replaced by a third number.
Also corrected in the PR body, not in the tree: "No `dist` is on the
resolved path" was true of the two ablation legs and false of the suite.
Measured on a fresh worktree with nothing built —
`pnpm --filter @objectstack/runtime exec vitest run
src/domains/automation-runs-query-validation.test.ts` cannot collect the
file at all: "Failed to resolve entry for package
@objectstack/observability". `http-dispatcher.ts`, which the suite
imports, imports that package; `packages/runtime/vitest.config.ts` has no
alias entry for it; its `exports` map serves `./dist/index.js`. The two
legs stay source-resolved and `ablation-dist-preflight` still does not
apply to them.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D47qPfEWVPmhguWgBZCi5N1 parent 0887423 commit bf70dbf
2 files changed
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1796 | 1796 | | |
1797 | 1797 | | |
1798 | 1798 | | |
1799 | | - | |
1800 | | - | |
1801 | | - | |
1802 | | - | |
| 1799 | + | |
| 1800 | + | |
| 1801 | + | |
| 1802 | + | |
| 1803 | + | |
| 1804 | + | |
| 1805 | + | |
| 1806 | + | |
1803 | 1807 | | |
1804 | 1808 | | |
1805 | 1809 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
181 | | - | |
182 | | - | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
183 | 185 | | |
184 | 186 | | |
185 | 187 | | |
| |||
0 commit comments