Commit ca326b5
docs(spec):
The docstring said "Only the submitter (or a system context) may recall", then
widened to `returned` requests in a second paragraph. Both halves were wrong:
- The list was not exhaustive. A #3424 override actor (platform or tenant
admin, holding no approver slot) may recall a `pending` request. The same
file already documented that 387 lines above, where the docblock on
`ApprovalRequestRow.viewer.can_override` spells the override's levers as
`(approve / reject / reassign / recall it)`.
- The ADR-0044 widening read as if it applied to that whole list. It does not:
the override and system arms are ANDed with `status === 'pending'` where they
are computed, so neither reaches a `returned` request (#12775, maintainer
ruling 2026-09-02). Abandoning a revision window is the submitter's alone.
Status is now the axis rather than a caveat appended to a general rule, so each
status carries its own admitted set. `ApprovalRecallInput.actorId` carried the
same stale sentence and is corrected with it. `ApprovalSendBackInput.actorId`
and `ApprovalResubmitInput.actorId` share the phrasing but are correct, since
`isOverrideActor` is never called from `sendBack` or `resubmit`.
Prose only: no key, no accepted value, no runtime behaviour moves.
Claude-Session: https://claude.ai/code/session_01G4138K1EG7kQ81FNba5Kp4
Co-authored-by: Claude <noreply@anthropic.com>IApprovalService.recall names every actor who may recall, scoped by status (#15645)1 parent 58f30d9 commit ca326b5
2 files changed
Lines changed: 44 additions & 9 deletions
File tree
- .changeset
- packages/spec/src/contracts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
540 | 540 | | |
541 | 541 | | |
542 | 542 | | |
543 | | - | |
| 543 | + | |
544 | 544 | | |
545 | | - | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
546 | 551 | | |
547 | 552 | | |
548 | 553 | | |
| |||
709 | 714 | | |
710 | 715 | | |
711 | 716 | | |
712 | | - | |
713 | | - | |
714 | | - | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
715 | 724 | | |
716 | | - | |
717 | | - | |
718 | | - | |
719 | | - | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
720 | 735 | | |
721 | 736 | | |
722 | 737 | | |
| |||
0 commit comments