Commit cd67471
committed
docs(types,metadata-protocol,changeset): state the split, and name the one surviving fallback
The census by rule found two claims carried in more than one place: a false
universal about what `(e as Error).message` did to an undeclared throw, and a
record formula that one of the fourteen call sites does not follow.
Over the five values pinned at the operator-text fallback case, that expression
did not answer one way. It read `undefined` for the string, the number and
`{}`, and it threw a `TypeError` for `null` and `undefined`. The pin's title and
the comment under it now state that split, which the shipped
`operatorFacingErrorText` docblock and both site docblocks already stated.
`seed-tenancy-backfill`'s organization probe keeps
`operatorFacingErrorText(e) || 'unknown error'`, so for an EMPTY channel it
records `'unknown error'`, not `''`. The metadata-protocol docblock, the pin
title that claimed every site, and the changeset -- which ships as release
notes -- now name that fallback and scope the formula to the other thirteen
sites. The fallback is load-bearing rather than leftover: the site reads an
empty value as "the probe did not fail", and with it removed an empty channel
routes the run down the benign no-organization-yet path. Whether it should go
is a behaviour question, tracked by #17167.
Two more sentences of the same class: the recognizer docblock now reads "a
NON-EMPTY sentence this fragment does not match" rather than "a DIFFERENT,
NON-EMPTY sentence", and `messageChannelOf`'s docblock no longer attributes
`undefined` to an expression that threw.
No behaviour change. 58 changed .ts lines, 54 comment and 4 title, 0 other;
comment-stripped and title-blanked hashes identical on all 13 .ts files; and
packages/types/dist/index.mjs, dist/index.js and dist/index.d.ts are each
byte-identical across this round.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XTBcV7zZHmokdyQgXjbyEU1 parent 82ee689 commit cd67471
4 files changed
Lines changed: 52 additions & 21 deletions
File tree
- .changeset
- packages
- metadata-protocol/src/migrations
- types/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
Lines changed: 26 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
31 | 47 | | |
32 | 48 | | |
33 | 49 | | |
| |||
303 | 319 | | |
304 | 320 | | |
305 | 321 | | |
306 | | - | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
307 | 329 | | |
308 | 330 | | |
309 | 331 | | |
| |||
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
| 143 | + | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
146 | 150 | | |
147 | 151 | | |
148 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
685 | 685 | | |
686 | 686 | | |
687 | 687 | | |
688 | | - | |
689 | | - | |
690 | | - | |
691 | | - | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
692 | 693 | | |
693 | 694 | | |
694 | 695 | | |
| |||
707 | 708 | | |
708 | 709 | | |
709 | 710 | | |
710 | | - | |
711 | | - | |
712 | | - | |
713 | | - | |
714 | | - | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
715 | 717 | | |
716 | 718 | | |
717 | 719 | | |
| |||
0 commit comments