Commit d2c906b
fix(triggers): point repository.directory at the directory the trigger packages actually live in (#15993)
* fix(triggers): point repository.directory at the directory the trigger packages actually live in
`@objectstack/trigger-record-change` and `@objectstack/trigger-schedule` both
declared a `repository.directory` under `packages/plugins/` that does not exist
in this repository, so the "Repository" deep link on their npm pages resolves to
a 404 instead of to their source. Both are published at 17.3.0.
@objectstack/trigger-record-change
was packages/plugins/plugin-trigger-record-change
now packages/triggers/trigger-record-change
@objectstack/trigger-schedule
was packages/plugins/plugin-trigger-schedule
now packages/triggers/trigger-schedule
Residue of two same-day renames, not one: `plugin-trigger-*` -> `trigger-*`
inside `packages/plugins/` broke the first segment, and the later promotion of
`packages/plugins/trigger-*` to a first-class `packages/triggers/` directory
broke the second. Both were pure directory renames with zero content changes, so
nothing rewrote the field.
Scope as a measured set, not a general claim: across all 81 tracked package.json
files, 57 declare `repository.directory`; 55 resolved to the manifest's own
directory before this change and 57 of 57 resolve after it. The 24 manifests
that declare no `repository.directory` at all are untouched here.
ADR-0041's `## References` section carried the same dead path as a source
pointer and is corrected with it. The rename table earlier in that record
(`plugin-trigger-record-change` -> `@objectstack/trigger-record-change`) is the
decision's own history and is deliberately left as written.
The corrected value ships inside the npm tarball, so it reaches readers only by
being published: a patch changeset accompanies the fix rather than
`skip-changeset`.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XpTx2tbq3pZRYAdoGt6E6Y
* docs(changeset): correct the residue account — a copy edited `name`, and a later commit edited the adjacent `url`
The shipped changeset claimed the stale `repository.directory` survived two
pure renames and that "nothing rewrote the field". Measured, that is false in
three ways, and the true account is a stronger argument for a mechanical check
rather than a weaker one.
f15d6f6 NOT a rename: a 26-file copy, +2222/-19, with all four
trigger directories briefly coexisting. Each copied manifest
differs from its original in exactly one line -- `name` -- so
this commit edited the manifest and left `directory` stale.
290c625 deleted the originals five minutes later.
ea4941a the only pure rename: 16 files, 0 insertions, 0 deletions.
9a43e04 six weeks later, rewrote `repository.url` and `bugs` in both
of these manifests. The stale `directory` line sits as
unchanged context ONE LINE BELOW the edited `url`.
The last point is the one worth the correction. "Nothing rewrote the field"
reads as the field never having been in anyone's way; in fact an author edited
its immediate neighbour inside the same JSON object and the dead line was on
screen in a reviewed hunk. A rule is more clearly needed when a human looked at
the line and still missed it, so this strengthens the case on the gate card.
No code change: the four-line metadata fix is unchanged and its verification
still stands. This commit corrects prose only, in the file that ships to
release notes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XpTx2tbq3pZRYAdoGt6E6Y
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent c463d03 commit d2c906b
4 files changed
Lines changed: 23 additions & 4 deletions
File tree
- .changeset
- docs/adr
- packages/triggers
- trigger-record-change
- trigger-schedule
Lines changed: 19 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | | - | |
195 | | - | |
| 194 | + | |
| 195 | + | |
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
0 commit comments