Commit d70428a
* fix(service-datasource): a declared ssl reaches the mysql client on the DSN branch (#8874)
The mysql arm resolved the TLS option and returned before it could be used,
so a datasource that declared TLS and wrote a config.url negotiated no TLS
at all. Carry it beside the DSN — mysql2 reads a uri and the ssl option as
separate channels — and only switch the bare-string return to an object when
a declared ssl actually resolved.
Also translates the resolved `true` into mysql2's spelling (`{}`): mysql2
throws `SSL profile must be an object` on a boolean, so the discrete-fields
branch was failing every connection acquisition for the same declaration.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y26DJEHSBhhAQ6wwfsHNza
* test(service-datasource): pin the declared mysql ssl on both branches and both DSN sub-cases (#8874)
Asserts at mysql2's own ConnectionConfig, fed the exact connectionSettings
knex hands it — the layer the sibling cards' reviews established, and the
only one that can see the boolean half of this defect.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Y26DJEHSBhhAQ6wwfsHNza
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent f2f09e4 commit d70428a
3 files changed
Lines changed: 513 additions & 11 deletions
File tree
- .changeset
- packages/services/service-datasource/src
- __tests__
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
0 commit comments