Commit e895dda
committed
docs(plugin-dev): the production doors are not uniform, in every carrier
The at-tier review's fail basis: this PR tightened the `os validate` clause in
two carriers and left it flat in three, while its own changeset called the flat
wording an overstatement.
Three named sites, all comment-only:
- dev-plugin.ts:386 -- the docblock sentence, which ships to dist/*.d.ts and
was a flat universal claim over BOTH rows of its own table.
- dev-plugin-malformed-stack-posture.test.ts:4 -- the file header.
- same file, the comment on the MISSING_IDENTITY case, which asserted the
false half about the very fixture it is attached to.
Extended to two more carriers so the PR does not ship a THIRD posture in 3 of 7
places -- content/docs/plugins/packages.mdx and the changeset -- because the
reading below falsifies their `build` half too, not only `os validate`.
Measured, first-hand, beyond what the review covered:
- `os build` is `compile.ts` (build.ts is `class Build extends Compile`), and
at compile.ts:347 it runs the SAME `ObjectStackDefinitionSchema.safeParse`
validate runs, exiting 1 at :352/:368. So both doors refuse a malformed
`packages[]`.
- compile.ts contains NO `manifest.id` requirement, and its own comment at
:967-971 says the structural advisories are absent because "os compile
never computes them at all (this file has no 'No objects defined' /
'may not do much' string, in any face)".
=> `os build` is SILENT on a stack with no `manifest.id`, so "build refuses
it" was overstated exactly as `os validate` was.
- validate.ts text face re-read at :760-774: `this.exit(1)` fires only inside
`if (flags.strict)`, confirming the `--json` ternary at :740 is not the
only exit and both read one `warnings` list.
- lower-callables.ts:315-319 passes a non-`{ manifest: object }` entry
through untouched, so the schema probe's verdict transfers to what the CLI
actually parses.
- `publish` is not a door this card measured; the claim is dropped rather
than restated.
Zero non-comment changed lines in both source files (classifier lit on a
planted code line). No behaviour change.
Claude-Session: https://claude.ai/code/session_01UDXER3sdqfeVYpEWZs5mZx
Co-authored-by: Claude <noreply@anthropic.com>1 parent a3f52cf commit e895dda
4 files changed
Lines changed: 43 additions & 17 deletions
File tree
- .changeset
- content/docs/plugins
- packages/plugins/plugin-dev/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
368 | 368 | | |
369 | 369 | | |
370 | 370 | | |
371 | | - | |
372 | | - | |
373 | | - | |
374 | | - | |
375 | | - | |
376 | | - | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
377 | 380 | | |
378 | 381 | | |
379 | 382 | | |
| |||
398 | 401 | | |
399 | 402 | | |
400 | 403 | | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
406 | 410 | | |
407 | 411 | | |
408 | 412 | | |
| |||
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
5 | 9 | | |
6 | 10 | | |
7 | 11 | | |
| |||
123 | 127 | | |
124 | 128 | | |
125 | 129 | | |
126 | | - | |
127 | | - | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
128 | 140 | | |
129 | 141 | | |
130 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
386 | | - | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
387 | 397 | | |
388 | 398 | | |
389 | 399 | | |
| |||
0 commit comments