Skip to content

Commit eafd626

Browse files
committed
ci(devx): run the platform-checklist gate's own self-test through its alias
`check:self-test-wired` reds the moment CI runs a script that ships a `--self-test` no workflow executes — and the watchdog makes CI run this one. Wiring the flag into the root alias is the remedy that gate names; a SELF_TEST_RUN_OTHERWISE row would be the finding written down somewhere quieter. The gate's header said a `--self-test` leg here "would execute NOWHERE". That premise is falsified by the watchdog, so the header is corrected rather than left to read as verified. The inline battery stays inline. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PU9zBGbH2s2ZtxSyu963M3
1 parent 2257e8e commit eafd626

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
"check:adr-links": "node scripts/check-adr-links.mjs --self-test && node scripts/check-adr-links.mjs",
8989
"check:adr-symbol-anchors": "node scripts/symbol-anchors.mjs --self-test && node scripts/check-adr-symbol-anchors.mjs --self-test && node scripts/check-adr-symbol-anchors.mjs",
9090
"check:scripts-symbol-anchors": "node scripts/symbol-anchors.mjs --self-test && node scripts/check-scripts-symbol-anchors.mjs --self-test && node scripts/check-scripts-symbol-anchors.mjs",
91-
"check:platform-checklist": "node scripts/checklist-select.mjs --self-test && node scripts/check-platform-checklist.mjs",
91+
"check:platform-checklist": "node scripts/checklist-select.mjs --self-test && node scripts/check-platform-checklist.mjs --self-test && node scripts/check-platform-checklist.mjs",
9292
"check:org-identifier": "node scripts/check-org-identifier.mjs --self-test && node scripts/check-org-identifier.mjs",
9393
"check:runner-env-posture": "node scripts/check-runner-env-posture.mjs --self-test && node scripts/check-runner-env-posture.mjs",
9494
"check:cli-test-child-env": "node scripts/check-cli-test-child-env.mjs --self-test && node scripts/check-cli-test-child-env.mjs",

scripts/check-platform-checklist.mjs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,17 @@ const err = (file, id, msg) => errors.push(`${file}${id ? ` · ${id}` : ''}: ${m
142142
// The battery runs inline, on every invocation, not only behind `--self-test`,
143143
// because a `--self-test` here would otherwise execute NOWHERE: this gate is
144144
// not CI-wired by maintainer decision (README "Operating cadence"), so nothing
145-
// on a PR would ever reach a `--self-test` leg. NOT because its `pnpm` alias is
145+
// on a PR would ever reach a `--self-test` leg.
146+
//
147+
// ⚠️ CORRECTED (#11730): the second half of that sentence no longer holds, and
148+
// the first half is unaffected. `.github/workflows/platform-checklist-watchdog.yml`
149+
// now runs this gate on `main` daily through its package script, so a
150+
// `--self-test` leg DOES execute somewhere — and the root alias
151+
// `check:platform-checklist` carries one, which is what `check:self-test-wired`
152+
// requires of every script CI runs. The gate is still NOT wired into per-PR CI;
153+
// only the reporting channel changed. The inline battery stays inline: a
154+
// `--self-test` that runs once a day is not a reason to stop running the cases
155+
// on the invocation whose verdict is being published. NOT because its `pnpm` alias is
146156
// unavailable to it: `check:platform-checklist` is already a key in root
147157
// package.json, and the reading that the #9465 fence covers that file is false
148158
// -- the GATE INVOCATION IDIOM note at the top of `.github/workflows/lint.yml`

0 commit comments

Comments
 (0)