Commit ecbb6fd
fix(examples): require the master on showcase field-zoo's f_master_detail (#14449)
* fix(examples): require the master on showcase field-zoo's f_master_detail
`showcase_field_zoo.f_master_detail` was the only `master_detail` declaration
across the loadable authored corpora that did not set `required: true` — a
detail record cannot exist without its master, and `objectstack validate` was
warning about exactly this one field (`relationship/master-detail-required`).
Both seeded zoo specimens already supply the value, so no data changes and
nothing turns red; this is example hygiene, and it zeroes the migration list a
future promotion of that rule from `warning` to `error` would produce.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
* test(dogfood): give the temporal-storage zoo fixtures a real master
`showcase_field_zoo.f_master_detail` is now required, and this suite creates
its zoo rows through the real REST write path supplying only `name` plus a
temporal field. Every insert answered 400 "Master-Detail → Project is
required", failing at `write f_time hm: expected 400 to be 201`.
The suite now seeds its own master chain in `beforeAll` — `showcase_account`,
then `showcase_project`, which declares a required lookup to the account, so
the order is forced — and passes that id to each of the four zoo inserts. The
epoch-rejection case gets it too, so the 400 it asserts is still about `f_time`
rather than about a missing master. Created rather than read out of the
showcase seed on purpose: this file's assertions rely on it owning every row it
reads.
Also corrects the comment that claimed the object "requires only `name`".
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDA48PuRFrHyRfdkBz8m21
---------
Co-authored-by: Claude <noreply@anthropic.com>1 parent 253da34 commit ecbb6fd
2 files changed
Lines changed: 46 additions & 3 deletions
File tree
- examples/app-showcase/src/data/objects
- packages/qa/dogfood/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| |||
Lines changed: 45 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
| 77 | + | |
| 78 | + | |
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
80 | 82 | | |
81 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
82 | 118 | | |
83 | 119 | | |
84 | 120 | | |
85 | 121 | | |
86 | 122 | | |
87 | 123 | | |
88 | 124 | | |
| 125 | + | |
89 | 126 | | |
90 | 127 | | |
91 | 128 | | |
| |||
94 | 131 | | |
95 | 132 | | |
96 | 133 | | |
| 134 | + | |
97 | 135 | | |
98 | 136 | | |
99 | 137 | | |
100 | 138 | | |
101 | | - | |
102 | | - | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
103 | 142 | | |
104 | 143 | | |
105 | 144 | | |
106 | 145 | | |
| 146 | + | |
107 | 147 | | |
108 | 148 | | |
109 | 149 | | |
| |||
198 | 238 | | |
199 | 239 | | |
200 | 240 | | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
201 | 244 | | |
202 | 245 | | |
203 | 246 | | |
| |||
0 commit comments