Commit fcddb13
committed
docs(service-analytics): retract the "more tightly than the proxy" clause from the case-exactness suite header
The round-1 contract review measured that clause false: FOLD_PER_DIALECT
inspects the COLUMN side only, so a one-sided column fold on the postgres /
unknown arm leaves this file green (exit 0, 14 passed) where the pre-fix
`LIKE translate($1,` pin caught it. The PR body and the changeset were
corrected in round 2; this source header was not, and a PR body cannot reach
someone who opens this suite six months from now.
The header now carries the two halves the PR body already states: tighter on
family separation (the four collapse mutations the review drove all went red
here), looser on both-sides folding, plus the cross-reference that
icontains-dialect-sql.test.ts holds the verbatim postgres / unknown byte pin
for that second case. Concluded as not net-weakened across the two files,
never as a strict tightening.
Comment-only, proven two ways with firing controls: every added and removed
diff line is a comment line (28 added, 8 removed, 0 non-comment; four real
code lines fed to the same filter classify as CODE), and the file transpiled
with removeComments is byte-identical to its 711db06 blob (sha256/16
941867ad0f3e45a7, 14888 bytes on both sides, while injecting one code line in
memory moves that hash). The other seven files this PR touches are untouched:
git hash-object equals the 711db06 blob for each.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XpTx2tbq3pZRYAdoGt6E6Y1 parent 711db06 commit fcddb13
1 file changed
Lines changed: 28 additions & 8 deletions
Lines changed: 28 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
83 | 103 | | |
84 | 104 | | |
85 | 105 | | |
| |||
0 commit comments