Skip to content

Commit fcddd15

Browse files
os-muskclaude
andauthored
docs(platform-objects): correct the vitest config's trailing effect claim (#16911)
The trailing comment opened "No `test` block" and closed "this file's only effect the alias above". Both were true as written (#7934/#8314): the file was this package's first vitest config and carried the alias and nothing else, as its own commit message records — "It carries the alias and nothing else: no `test` block". Both were falsified in place when the console-intercept disarm landed ABOVE them and left them standing (#10374/#13522). Measured on 44c849c: the file opens with a `test` block whose one key is `disableConsoleIntercept: true`, so there IS a test block and the alias is NOT the only effect. The load-bearing half of that sentence is kept intact and now stands on its own: discovery is still untouched (zero `include`/`exclude`/`dir` keys in the file), and narrowing `include` here would still silently drop cases while the gate this file answers went green. The retired wording is paraphrased rather than quoted, so a census grep for the old phrasing does not land back on this file. Config-only, publishes nothing: the file is absent from the package tarball and its text reaches zero dist files, while a control src JSDoc reaches six. Claude-Session: https://claude.ai/code/session_01ADLdAs2pVcH17h9tZKWMBg Co-authored-by: Claude <noreply@anthropic.com>
1 parent 5abca17 commit fcddd15

1 file changed

Lines changed: 18 additions & 5 deletions

File tree

packages/platform-objects/vitest.config.ts

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,10 +62,23 @@ export default defineConfig({
6262
},
6363
],
6464
},
65-
// No `test` block: this package had no vitest config until now, so its suite
66-
// ran on vitest's defaults. Leaving discovery untouched keeps this file's only
67-
// effect the alias above — the sweep's population floors (76 object files / 51
65+
// Discovery is untouched — but this file is NOT "the alias and nothing else".
66+
// The `test` block above carries exactly one key, and it is a run-exit fix
67+
// (`disableConsoleIntercept`, #10374), not a discovery key: no `include`,
68+
// `exclude` or `dir` is set anywhere here, so this package's suite is still
69+
// discovered on vitest's defaults, as it was before this file existed.
70+
//
71+
// Narrowing `include` here would silently drop cases while the gate this file
72+
// answers went green: the sweep's population floors (76 object files / 51
6873
// in-scope / 9 packages) are measured by walking the filesystem, but the rest
69-
// of the package's suite is discovered by vitest, and narrowing `include` here
70-
// would silently drop cases while the gate this file answers went green.
74+
// of the package's suite is discovered by vitest.
75+
//
76+
// The two claims this paragraph replaces — that a `test` block was absent
77+
// here, and that the alias was this file's sole effect — were true as written
78+
// (#7934/#8314), and were falsified in place when the disarm landed ABOVE them
79+
// and left them standing (#10374/#13522): the same silent staleness the alias
80+
// rationale above records against its own suite count. Deleting or rewriting
81+
// this config now costs the disarm as well as the alias (#16189). Paraphrased
82+
// rather than quoted, so a census grep for the retired wording does not land
83+
// back on this file.
7184
});

0 commit comments

Comments
 (0)