Skip to content

[finding] six comments in three packages describe the standalone stamp as proj_local after the #13366 rename lands #15202

Description

@os-litant

Blocked-by: #13366

Recorded by the os-dev seat while implementing the ruled scope of #13366 — the PR is #15200. Out of scope for that PR by explicit ruling: its scope list is two files plus a changeset, and "nothing beyond it". Recorded rather than fixed.

⚠️ This is not yet true on main — it becomes true the moment #15200 lands. Until then the comments below are accurate and there is nothing to do here.

What moves

#13366's ruling finishes the v5.0 project to environment rename at the two stamps it never reached: packages/runtime/src/standalone-stack.ts and packages/metadata/src/plugin.ts stamp env_local instead of proj_local. The ruling deliberately touches nothing else.

Six comments in three other packages describe that stamp by its old spelling. After the rename lands they describe a value the tree no longer produces.

site text tense
packages/metadata-protocol/src/protocol.ts:4747-4748 "os dev / os start bind env_local, the standalone artifact stack proj_local, a cloud per-project kernel its own" present — enumerates what each boot binds today
packages/metadata-protocol/src/plugin.ts:133 "the standalone stack stamps 'proj_local' on every os dev / os serve / os start / os migrate boot" present
packages/metadata-protocol/src/plugin.ts:279 "'proj_local', so this whole block never armed on a self-hosted install" past, quoting the same stamp
packages/objectql/src/plugin.ts:123 "the standalone stack stamps 'proj_local', so the three migrations never armed" present clause inside a past explanation
packages/cli/src/utils/schema-migrate.ts:299 "the assembly deduced "cloud per-project kernel" from the 'proj_local'" past
packages/cli/src/utils/platform-migrations-arming.integration.test.ts:15 "runtime/src/standalone-stack.ts stamps 'proj_local' on every boot" present, file header; the assertions never read the literal, so nothing goes red

Why this is a card and not a rider on that PR

Two reasons, and the second is the substantive one.

  1. [finding] the default/local-dev environment id has three spellings — proj_local, env_local and default — and one consumer deliberately accepts two of them #13366's ruling enumerates its scope and forbids anything beyond it. packages/metadata-protocol, packages/objectql and packages/cli are not on it.
  2. These are not all the same edit. The present-tense ones become simply false and want the new spelling. The past-tense ones narrate the pre-The three kernel:ready migrations in assembleMetadataProtocol never arm on a self-hosted boot — the standalone stack stamps environmentId = 'proj_local', and the gate asks for undefined #9380 / pre-#4463 运行时发布门在 host-config 拓扑(environmentId 未绑定)上整体不跑——#5086 只把 code-only 拒绝移出了同一条短路 #6710 deduction as history, and the sibling doc content/docs/deployment/seed-tenancy-repair.mdx was ruled untouchable on exactly that ground — "its text is true history". Deciding which of the six is history and which is a stale description of today is a judgement per site, not a search-and-replace. A blanket rewrite would falsify the historical ones in the other direction.

⚠️ Note for whoever takes it: the causal claim in all six is about presence, not spelling — the retired gate read environmentId === undefined, so it would have misfired identically under either literal. Preserve that, and do not "correct" a sentence into implying the spelling was the cause.

Grade

Comment accuracy only. No behaviour, no gate, nothing user-visible. Nothing goes red at any spelling: the only live code branch on either literal (packages/cloud-connection/src/cloud-connection-plugin.ts:177) puts both spellings in the same arm, and no test in these files asserts the literal.

Re-check

git grep -n "proj_local" -- packages/metadata-protocol packages/objectql packages/cli

Reverse-check any zero against git grep -c environmentId over the same paths — a zero from a mis-scoped pathspec and a zero from a clean tree look identical.

Duplicate check

One targeted search this round, with its positive control run first: the control returned the known-present #13366 for the same query shape, so the reading is a reading and not a broken instrument. #13366 is the only other open card on either literal; it is ruled and scoped and explicitly excludes these paths. ⚠️ Not exhaustively deduped beyond that one search, and search is known to miss minute-fresh cards.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions