Skip to content

[finding] platform-objects vitest.config.ts still says "No test block" and "this file's only effect the alias" — both false since the console-intercept disarm landed above it #16189

Description

@claude

Filed by the #16081 execution round (PR #16188), which found it in the file it was repairing but left it alone: #16081's dispatch pins the surface to the alias rationale comment, and this is a different sentence. ⛔ Unassigned and ungraded — domain:*, type and priority are triage's.

The finding

packages/platform-objects/vitest.config.ts ends with a comment that opens:

// No test block: this package had no vitest config until now, so its suite
// ran on vitest's defaults. Leaving discovery untouched keeps this file's only
// effect the alias above ...

Both halves are false on main today. The same file opens with a test block:

  test: {
    // A late console.* must not redden a green suite (#10374) ...
    disableConsoleIntercept: true,
  },

So there is a test block, and the alias is not this file's only effect.

Why it is worth a card

Same defect class as #16081, in the same file: a comment that licenses an action it no longer justifies. "This file's only effect is the alias above" tells a future author that deleting or rewriting this config costs only the alias. It also costs disableConsoleIntercept: true, whose own comment three lines up says it exists so that a late console.* cannot turn a fully green suite into exit 1.

⭐ The consequences are not symmetric, which is why this reads lower-severity than #16081 rather than equal: the console-intercept disarm is separately enforced repo-wide by scripts/check-console-intercept-disarm.mjs, so removing it fails loudly. #16081's alias had no such second guard — losing it fails green. This one is a false statement that a gate would catch; that one was a false statement nothing would catch.

No remedy prescribed. Rewriting the paragraph, splitting it so the surviving half (the include argument, which is still true and still worth keeping) stands on its own, or deleting the lead sentence are all open.

Dedupe, with controls

Enumeration proven COMPLETE: 643 open issues fetched by repo-scoped REST list (pull requests excluded) plus 29 open PRs = 672, and the repo's own open_issues_count reads 672. Channel note: /search/issues answers 403 for this session ("sessions are bound to their configured repositories"), so this is the repo-scoped list endpoint plus local matching, at zero MCP cost.

probe hits
No test block 0
disableConsoleIntercept 0
only effect the alias / file's only effect 0
platform-objects/vitest.config 1 — #16081 only, whose scope is explicitly the alias rationale sentence
CONTROL vitest.config 5 — fires
CONTROL platform-objects 28 — fires
CONTROL stale-comment phrasing 2 — fires

⇒ No open issue names this. All three controls fire on the same corpus and the same command, so the zeros are real absences rather than a broken instrument.

Refs

#16081 (the card this was found under) · PR #16188 · scripts/check-console-intercept-disarm.mjs


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions