You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[finding] the two plugin-type-closed-set pins still say core "has no typecheck script", and the rest pin header keeps the "refused it at parse" wording #16049 measured false #16602
Observation from #16334, filed unassigned — comment drift only, no behaviour.
packages/core/src/plugin-type-closed-set.test.ts (header, lines 14-22) and packages/rest/src/plugin-type-closed-set.pin.test.ts (header, lines 9-17) both explain the pins' placement by "@objectstack/core has no typecheck script (it is a type-check DEBT ledger entry)". On the current tree packages/core/package.json declares typecheck (tsc --noEmit && tsc --noEmit -p tsconfig.examples.json && pnpm check:test-typecheck), and pnpm --filter @objectstack/core typecheck runs green (measured on the spec: PluginSchema makes staticPath / slug really required for type: "ui" (superRefine), and core's Plugin interface derives from PluginDefinition (spec half of #16049) #16334 branch, commit 8dc4a33). The placement argument for the rest-side directives may still hold for another reason — the rest test program reads core's BUILT .d.ts, which is the published contract — but the sentence that currently justifies it is false.
Suggested fix: one docs-only commit rewriting both headers against the current tree (core has a typecheck script; the refusal is on the boot path since #16363), with no change to the pins themselves. Left out of #16334 (PR #16598) by scope: that PR adds one pin to the rest file and one helper to the core file, and the sentences above are historical prose outside its diff.
Observation from #16334, filed unassigned — comment drift only, no behaviour.
packages/core/src/plugin-type-closed-set.test.ts(header, lines 14-22) andpackages/rest/src/plugin-type-closed-set.pin.test.ts(header, lines 9-17) both explain the pins' placement by "@objectstack/corehas notypecheckscript (it is a type-check DEBT ledger entry)". On the current treepackages/core/package.jsondeclarestypecheck(tsc --noEmit && tsc --noEmit -p tsconfig.examples.json && pnpm check:test-typecheck), andpnpm --filter @objectstack/core typecheckruns green (measured on the spec:PluginSchemamakesstaticPath/slugreally required fortype: "ui"(superRefine), and core'sPlugininterface derives fromPluginDefinition(spec half of #16049) #16334 branch, commit 8dc4a33). The placement argument for the rest-side directives may still hold for another reason — the rest test program reads core's BUILT.d.ts, which is the published contract — but the sentence that currently justifies it is false.packages/rest/src/plugin-type-closed-set.pin.test.tsline 7 still says the Zod gate "refused it at parse". [finding] PluginSchema has zero runtime callers — the boot path validates name, init and semver only, so the declared plugin contract is never enforced #16049's measurement (from [finding]plugin-hono-serverstill accepts the legacyui-plugintype thatPluginSchemarefuses — an unreachable arm under ADR-0049 #15638) is that nothing parsed plugin objects until feat(core): enforce PluginSchema at kernel.use() (#16049) #16363; core'stypes.tsdocblock was rewritten to say so, this header was not. Card spec:PluginSchemamakesstaticPath/slugreally required fortype: "ui"(superRefine), and core'sPlugininterface derives fromPluginDefinition(spec half of #16049) #16334 attributed that wording tocore/src/types.ts:127; on the current tree it survives only here.Suggested fix: one docs-only commit rewriting both headers against the current tree (core has a typecheck script; the refusal is on the boot path since #16363), with no change to the pins themselves. Left out of #16334 (PR #16598) by scope: that PR adds one pin to the rest file and one helper to the core file, and the sentences above are historical prose outside its diff.