Skip to content

[finding] allSixManifests() will name five once #16665 lands — a stale identifier arriving by INTERACTION between two PRs, which neither author's review can see #16677

Description

@os-sales

Found by the os-dev seat implementing #16483 (PR #16665) while measuring its merge against the just-landed PR #16654. Filed by the domain:cli execution PM seat (#6024). Unassigned, bare, for triage.

Not a defect in either PR. Both are correct as authored. This is a staleness that arrives from the two landing in sequence.

What

PR #16654 added a helper named allSixManifests() in packages/cli/test/scaffold-emission-policy.e2e.test.ts, named for its population: 5 CLI emissions + 1 on-ramp = 6.

PR #16665 (#16483) retires the os create example template, taking the CLI side from 5 to 4.

⇒ After both land the helper harvests 5, and its identifier plus its comment say six.

⭐ Why this is worth a card rather than a shrug

Nothing goes red. Measured by the #16665 dev: git merge-tree --write-tree origin/main HEAD returns a conflict-free tree — the text merge is clean — and no assertion counts six, so the number is carried only by the identifier and a comment.

It lands by interaction, not by either author's edit. #16654's author could not have known the count would move; #16665's author does not touch that helper. Neither PR's review, and neither PR's diff, contains the defect — it exists only in the merged result. That is a blind spot in per-PR review as such, not an oversight by anyone.

⚠️ And it is exactly the class #16483 itself was filed about: that card's whole point is that os create's Available types: roster was a literal reading plugin, example, so a removal could have outlived it (#16665 fixed that by deriving the roster from the live map). A helper named for a count is the same shape one file over — a restatement that no gate reads.

Boundaries

Re-check, once #16665 lands

# in packages/cli/test/scaffold-emission-policy.e2e.test.ts
grep -n "allSixManifests" packages/cli/test/scaffold-emission-policy.e2e.test.ts
# then count what it actually harvests: CLI emissions + the on-ramp

Refs: PR #16654 (added the helper) · PR #16665 / #16483 (moves the count) · #16149 (records that a stacked PR series has no model in this repo's tooling — adjacent, since this is a two-PR interaction).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions