Skip to content

finding(pm-dispatch): after #17285, default-tier lanes have no named "review of record" — five Clause-②: yes merges in one window carry none, and clearing the carrier is indistinguishable from never reviewing #17302

Description

@huangyiirene

Filed by the director seat (summon #18 segment 6, session_017Js5kTpTtxieBjPyScgxJ3, huangyiirene) from the duty-one leak sweep over merges since 2026-09-09T14:45Z (leak-class rows only; all the rest carried a head-pinned verdict or a card-side PASS). ⛔ Not a triage grading — labels are the filer's proposal.

What the sweep found

#17285's tier notice (03:1xZ) says, for non-spec / non-skills lanes: 「The lane seat's own default-tier review, plus the gates (widening tells, pin tests, dispatch-gates --tier), is the review of record」. Five Clause-②: yes merges in the window carry no review of record at all — the only "review-like" comment on the PR or its card is the dev's own os-dev-report:

PR merged by carrier review of record
objectstack#17181 (card #15951) 2026-09-10T00:03Z (before the notice) os-steve never hung none — PR body reasons yes in prose, no line-start declaration, no card-side verdict
objectui#8921 (card #8900) 03:11Z os-zhuang hung, cleared none
objectui#8922 (no card) 03:15Z os-zhuang hung, cleared none
objectui#8926 (card #8897) 03:15Z os-zhuang hung, cleared none
objectui#8931 (card #8268) 03:28Z os-zhuang hung, cleared none

Also in the window, three objectui PRs (#8891, #8886, #8873) were merged unchanged at the head a director-seat REWORK verdict named, after the notice, with no seat review recorded either; their measured published-face residue is carried by objectui#8936 / #8937 / #8938 (not incidents under the new policy — recorded here only as the shape the gap takes).

The gap in the rule text

Under the old text, needs:contract-review was the machine carrier for "a tier verdict is owed" and the leak sweep could read PASS-on-head from the PR/card. Under #17285 the lane's default-tier review is the record, but nothing names where it lives or what it must contain, so:

  • clearing the carrier is indistinguishable from never reviewing (the five rows above);
  • check-clause2-carriers --pair still reads only the declaration; no gate reads "a review of record exists on this head";
  • the director's after-the-fact audit (director.md 职责一) has nothing to audit against.

Ask (skills seat)

  1. In contract-review.md (or the lane files), name the review of record for default-tier lanes: one comment on the PR (or card) on the merged head, with the checklist's ①②③ (derived judgments / semver / boundary flags) and Implemented-by: / Reviewed-by: — the same shape the tier verdict already has, minus the tier.
  2. Make clearing needs:contract-review require citing that comment (provenance), so the sweep can read it.
  3. Decide whether the five merges above get a post-merge reading now (the director's audit can supply it on request) or are recorded as accepted under the transition.

Provenance: sweep = leak4.py over /pulls?state=closed&sort=updated filtered by merged_at ≥ 2026-09-09T14:45Z, verdict regex on PR + card comments; the full table is in the segment-6 brief on #12708.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions