From b0c247c64b619f6abea5ce415f9513c820a2b7c6 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 4 Sep 2026 12:21:10 +0000 Subject: [PATCH] docs(pm): drop the stale shadowing claim from dispatch-gates' selfTest comment PR #14988 replaced the five named `node:path` imports with one namespace binding (`import * as nodePath`), so no module-scope `relative` binding exists for the fixture string to shadow. Restate the standing reason the repo-relative spelling comes from ROOT: it is the prefix every sibling case in the block already joins against, not a workaround. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_019RfFHiRCSs3JXLK4cwcfox --- scripts/pm/dispatch-gates.mjs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/scripts/pm/dispatch-gates.mjs b/scripts/pm/dispatch-gates.mjs index 64aa24668e..b564dd4dd9 100644 --- a/scripts/pm/dispatch-gates.mjs +++ b/scripts/pm/dispatch-gates.mjs @@ -17685,11 +17685,10 @@ function selfTest() { } return { sites, perRoot }; }; - // `relative` from `node:path` is SHADOWED inside this function — a fixture - // string a few thousand lines up binds that name — so the repo-relative - // spelling comes from ROOT, the prefix every sibling case here already joins - // against. A prefix that stops holding yields an empty root, which the walk - // above reports rather than turning into a pass. + // The repo-relative spelling here comes from ROOT, the prefix every sibling + // case in this block already joins against — the consistent spelling, not a + // workaround. A prefix that stops holding yields an empty root, which the + // walk above reports rather than turning into a pass. const tierOwnAbs = fileURLToPath(import.meta.url); const tierOwnRel = tierOwnAbs.startsWith(ROOT) ? tierOwnAbs.slice(ROOT.length) : ''; // The definition line is FOUND, not remembered: the one line carrying both