finding(vscode-extension): `Export to React` generates a file that cannot compile — its preamble calls `registerDefaultRenderers`, an export `@object-ui/components` does not have

[claude]

Found while fixing the root README's three phantom imports for #7417. Out of that
card's file surface (root README.md plus one ledger string), so it is filed rather
than edited.

The defect

packages/vscode-extension/src/extension.ts:225 — generateReactComponent(schema),
the body of the extension's Export to React command (called at line 203) — writes
a React file into the user's workspace whose first lines are:

packages/vscode-extension/src/extension.ts:230   import { registerDefaultRenderers } from '@object-ui/components';
packages/vscode-extension/src/extension.ts:233   registerDefaultRenderers();

registerDefaultRenderers is on no export of @object-ui/components. Measured
against the built artifact on origin/main at 900f8d99:

• grep -c registerDefaultRenderers packages/components/dist/index.d.ts returns 0.
• The only register* on that package's built dist/index.d.ts is
  registerPlaceholders.

So every invocation of Export to React emits a file that does not compile, and the
error the user sees names a symbol they never typed.

What the correct output is

That package registers its renderers as an import side effect — no call needed:

• packages/components/package.json declares sideEffects: true.
• packages/components/src/index.ts runs import './renderers'; under the comment
  Register all ObjectUI renderers (side-effects).
• The built dist/index.js carries 114 top-level register( calls.

The generated preamble should therefore import the package for the side effect and
drop the call. The root README was carrying the identical wrong lines and is fixed
that way in the PR for #7417, so there is a landed spelling to copy.

packages/vscode-extension/DESIGN.md:272,274 documents the same two lines and needs
the same edit.

Why no gate caught it

The phantom lives inside a template literal, so TypeScript cannot see it and the
doc gates never reach it either:

• scripts/check-doc-snippet-types.mjs's scan surface is content/docs, the per-app
  docs trees, packages/NAME/README.md, and the root README.md. DESIGN.md is not
  a README.md, so that file is outside it.
• scripts/check-readme-exports.mjs tracks packages/NAME/README.md only.

A generator that emits import statements is a documentation surface with no gate,
which is why this survived while the same two lines in a README did not.

Severity note

packages/vscode-extension is private: true, so nothing is published from it and no
changeset is owed for a fix here. The blast radius is the extension's own users.

---

Generated by Claude Code

[claude]

Claim: PM 席（domain:ui lane）认领本卡并派发给 os-dev 执行席。

• Session: https://claude.ai/code/session_01KbJQ1y1J12nZxYzFWhP8Q3
• Branch: claude/issue-7837-vscode-export-react-phantom
• Worktree: /home/user/objectui-issue-7837
• Domain: domain:ui
• File surface: packages/vscode-extension/src/extension.ts 的 generateReactComponent() 模板，以及 packages/vscode-extension/DESIGN.md（记录同样两行的那处）。⛔ 不出这个包。
• Container & model: 本会话容器 · opus
• Clause-②: no
• Serial constraints cleared: 同 lane 在飞的卡落在 scripts/check-eager-closure-budget.*、content/docs/guide/expressions.md、examples/schema-catalog/test/、docs/ARCHITECTURE.md —— 与 packages/vscode-extension/ 不相交。

PM 裁定

这张卡的严重性比 p3 的外观高：发布的代码在生成坏代码

generateReactComponent() 是 Export to React 命令的主体，它往用户拿到的每一个文件里写入 registerDefaultRenderers from @object-ui/components —— 那个符号不存在。而且它藏在模板字符串里，所以 TypeScript 看不见它：本包的 type-check 永远绿，坏的是产物。

⇒ ⭐ 这是本轮反复出现的那个形状的又一例：验证者与被验证物之间没有绑定关系。⛔ 修完这两行之后，请在报告里回答一句：有没有便宜的办法让这个模板的产物被某个仪器看到？（例如把模板产物在测试里编译一次）。⚠️ 只交读数与提案，⛔ 不要在本卡里建那个仪器。

正确拼法：抄 PR #7836 的实测结果，⛔ 不要自己推

#7417 的执行席已经量过并落地了：

幽灵	实测正确写法
registerDefaultRenderers from @object-ui/components	副作用 import —— @object-ui/components 声明 sideEffects: true，barrel 跑 import './renderers'，其构建产物 dist/index.js 里有 114 个顶层 register( 调用 ⇒ 根本不存在注册函数
（若模板里还有 ObjectRenderer）	plugin-view 的 ObjectView，⛔ 不是 app-shell 的那个 —— 后者不接受 objectName（从 useParams() 读）、还需要 objects 元数据数组、整个 props 面是 any（#7483）。⭐ 裸改名会在门上变绿而运行时仍然坏

⚠️ 这两条都要你在今天的树上自己复核，⛔ 不要采信本裁定。

一起做

DESIGN.md:272,274 记录了同样两行 ⇒ 同一笔里改掉，否则它立刻变成一条冻结的错误记录（本 lane 今天已经处理过四张这个形状的卡）。

边界

• Clause-② no：⛔ 不新增导出、不改签名。
• packages/vscode-extension 是私有包（不发布）⇒ 大概率不欠 changeset。⛔ 仍要跑 node scripts/check-changeset-presence.mjs 并原样引用判词，别靠推理跳过。
• ⚠️ 模板产物的其余部分你可能会顺手看出别的问题 —— ⛔ 不要顺手改，报回。本卡只修这个幽灵。
• ⭐ 若能给这两行加一条钉子（哪怕只是断言模板字符串里不出现这个标识符），那就把「靠人读」换成「靠门」。⛔ 做不进来就报形状。

---

Generated by Claude Code

[claude]

os-dev-report

{
  "issue": 7837,
  "status": "done",
  "branch": "claude/issue-7837-vscode-export-react-phantom",
  "pr": "https://github.com/objectstack-ai/objectui/pull/7863",
  "premise_still_valid": true,
  "summary": "The card's premise held in full and both spellings were re-measured on today's tree (3faaa7d0f) rather than taken from the dispatch. generateReactComponent() in packages/vscode-extension/src/extension.ts now emits a side-effect import of @object-ui/components instead of importing and calling the phantom registerDefaultRenderers; DESIGN.md's copy of the same two lines moves in the same commit. The ObjectRenderer row of the ruling has no site here: the template's only other import is SchemaRenderer from @object-ui/react, which is a real export and type-checks, so nothing was renamed. Two things went against the dispatch's expectation and are reported rather than reasoned past: (1) a changeset IS owed - object-ui is private but sits in the changesets fixed group with privatePackages.version true, and check-changeset-presence exited 1 naming packages/vscode-extension/src/extension.ts, so .changeset/7837-vscode-export-react-side-effect-import.md declares patch; (2) landing the pin cost a second commit, because check-type-check-coverage exited 1 on a test file no tsc program read - closed with a tsconfig.test.json chained off the package's type-check script, the shape 35 sibling packages already use. Clause-2 stayed no: no export added, no signature changed. Six files, all inside packages/vscode-extension plus the changeset.",
  "tests": "THE READING THAT MATTERS - the command's OUTPUT, not this package's type-check. generateReactComponent() is module-private and clause-2 forbids exporting it, so a harness brace-matches the function out of the source file on disk, strips its two type annotations, evaluates it and calls it with a representative page schema; the emitted file is compiled against the BUILT dist/index.d.ts of @object-ui/react and @object-ui/components (jsx react-jsx, strict, skipLibCheck). BEFORE: tsc exit 2, one diagnostic - \"Generated.before.tsx(3,10): error TS2305: Module '\\\"@object-ui/components\\\"' has no exported member 'registerDefaultRenderers'.\" AFTER at bf51ca4ef: tsc exit 0, no output. End to end, the tsup-built dist/extension.js that goes into the .vsix carries 0 occurrences of registerDefaultRenderers and one side-effect import. RE-MEASURED CLAIMS at 3faaa7d0f, both built first: registerDefaultRenderers occurs 0 times in packages/components/dist/index.d.ts and 0 times in dist/index.js, the only register* export being registerPlaceholders; sideEffects true in the manifest, import './renderers' in the barrel, and 114 register( call sites at module scope in dist/index.js (e.g. n.register(\"div\", ...) at column 0 of the ESM bundle). PIN + ABLATION: packages/vscode-extension/src/__tests__/export-to-react-preamble.test.ts, 3 assertions, runs under the package's own test script and the root vitest unit project. Ablation was run against the COMMITTED fix: restoring extension.ts from 3faaa7d0f turned 2 of 3 assertions red (the third pins the untouched SchemaRenderer line and correctly stayed green). The mutation was confirmed ON DISK before the run - registerDefaultRenderers count 2, side-effect-import count 0, the script aborting otherwise - and the restore was verified by git diff HEAD being empty AND git hash-object reproducing the HEAD blob e52b0abc15a2d84305e2ab8080819e8e15029139. NO BUILD is involved on either leg: the pin reads source text, not dist, so there is no dist/ staleness to rebuild away. The script carried a trap on EXIT INT TERM with an absolute repo-root path. GATES, all at bf51ca4ef with the exit code captured by redirecting before any pipe: object-ui type-check 0 (echoed 'tsc --noEmit && tsc -p tsconfig.test.json' - both legs, and tsc -p tsconfig.test.json --listFiles confirms the project reads the pin); object-ui test 0 ('Test Files 1 passed (1) - Tests 3 passed (3)'); object-ui lint 0 ('13 problems (0 errors, 13 warnings)', unchanged from before this PR, and eslint --format json reports the new test file with 0/0, so it is linted and not ignored); object-ui build 0. check-changeset-presence 0, verbatim: '2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s): .changeset/7837-vscode-export-react-side-effect-import.md.' Also 0: check-changeset-fixed, check-changeset-no-major, check-type-check-coverage ('42/42 packages compile their tests'), check-lint-coverage ('46/46 packages linted'), check-control-bytes (plus a direct grep -naP control-byte scan of all six changed files: clean), check-unreferenced-sources, check-vi-mock-specifiers, check-vi-mock-inherit, check-doc-fence-languages, check-package-self-import, check-published-tsconfig-tooling-exclude, check-entry-guard, check-shell-escape-residue, check-phantom-dependencies, and check-governed-queue-guard --test ('NOT GOVERNED - 6 path(s) checked against 5 governed surface(s); none matched'). All heavy runs went through objectstack/scripts/pm/os-verify-lock.sh with slot issue-7837-dev; longest queue wait 99s. NOT RUN, stated plainly: the whole gate farm (CI runs it regardless); pnpm lint / turbo run lint across all 46 packages and every other package's test suite - this diff does not leave packages/vscode-extension and that package's own lint and test are its complete population, and eslint.config.js declares no project/projectService so no rule reads across files; check-published-dist-tooling, which needs a full repo build and skips private packages by construction so object-ui is outside it either way; and the extension inside a running VS Code instance - there is no headless VS Code host here, and compiling the command's own output is what stands in for it.",
  "mcp_calls": "0 - every GitHub action in this run used repo-scoped REST with $GITHUB_TOKEN (issue read, comments read, PR 7836 read, label-scoped dedup listings, issue creation, PR creation, and every read-back). No MCP GitHub tool was called. /search/issues answered 403 as the dispatch said, so dedup used label-scoped REST listings paged to exhaustion - label 'finding' 177 open issues over 2 pages, label 'domain:devx' 93 over 1 page, 210 distinct - with objectui#7837 itself as the known-hit control, present in both listings.",
  "open_questions": [
    {
      "question": "PM asked for a reading and a proposal only: is there a cheap way to put this template's OUTPUT in front of an instrument? Reading: today nothing reads it. The preamble is a template literal, so tsc sees a string; tsup copies it through; check-doc-snippet-types.mjs's scan surface is content/docs, the per-app docs trees, packages/NAME/README.md and the root README.md, and check-readme-exports.mjs tracks packages/NAME/README.md only - neither reaches src/. The class is not a one-off: objectui#7472 records an eighth lucide icon-name resolver emitted inside a template literal in cli/app-generator.ts with zero normalisation. Which instrument?",
      "options": [
        "A - Source-text pins, what this PR shipped. Cost: zero new deps, no export moved, ~100 lines. Catches the return of a KNOWN phantom and the loss of its replacement; cannot catch a NEW one. Already landed, so it is the floor rather than an alternative.",
        "B - Compile the emitted output inside a vitest test in this package. Move the template into its own module (or export the function) so a test can call it, emit for a representative schema, and run the TypeScript compiler API over the result asserting zero semantic diagnostics. Cost: this package's deps are only @object-ui/core and @object-ui/types, so it needs @object-ui/react and @object-ui/components as devDependencies plus a turbo build edge onto them - a real dependency and build-graph change to a package that today builds in 23ms. Catches any phantom in this one template, forever.",
        "C - Extend check-doc-snippet-types.mjs to a new scan surface: code-EMITTING template literals under packages/*/src/**, compiled with the machinery it already has (its analyze()/compileSnippets() and its scoped build closure). Cost: one gate script plus an opt-in marker or path list so it does not try to compile every template literal in the repo. Catches the whole CLASS - this template, cli/app-generator.ts's, and the next generator someone writes - and adds no dependency to any package.",
        "D - Do nothing beyond A and accept that generated code is unverified."
      ],
      "recommendation": "C. It closes the class rather than one site, and it is the only option that costs no package-level dependency or build edge: the gate already builds a scoped closure and compiles snippets against built .d.ts files, which is exactly the work B would duplicate inside this package. A generator that emits import statements is a documentation surface - the card body says so - and that gate is the repo's documentation-surface compiler. B is the right answer only if the goal is narrowly this one template and the dependency cost is acceptable; A alone is not enough, because it is definitionally blind to the next phantom."
    }
  ],
  "out_of_scope_findings": [
    "filed as #7862 (no assignee, no labels, dedup-searched first): the same generated file opens with an import of React from 'react' while its only JSX is a single SchemaRenderer element, so under jsx react-jsx the identifier is never read - the same output compiled with noUnusedLocals true added is tsc exit 2 with \"TS6133: 'React' is declared but its value is never read.\" A different defect class from this card (a real import that is unused, not a symbol that does not exist), and dropping the line is a decision about classic-transform users, so it is filed rather than corrected in passing.",
    "not filed, reported here because the dispatch asked for the reading rather than the build: packages/vscode-extension had ZERO test files before this PR, and its test script is 'vitest run --passWithNoTests --root ../.. packages/vscode-extension/', so the package was structurally green with nothing to run - the same no-binding-between-verifier-and-verified shape as the card itself. This PR gives it one test file; the package still has no test for anything other than the export template.",
    "not a finding but a correction to the dispatch's expectation, recorded so the next seat does not repeat it: packages/vscode-extension being private:true does NOT mean no changeset is owed. object-ui is private because it ships to the VS Code marketplace rather than npm, but it is in the changesets fixed group with privatePackages.version true, so changesets versions it and writes its CHANGELOG. check-changeset-presence exited 1 on the first run and named the file."
  ]
}

---

Generated by Claude Code