Skip to content

finding(docs): docs/ARCHITECTURE.md and docs/CONSOLE-STREAMLINING-SUMMARY.md attribute three more renderer names to @object-ui/app-shell, and all three are wrong in different ways #7854

Description

@os-sam

Found while fixing the ObjectRenderer phantom in these same two files for objectui#7838. Out of that card's enumerated line surface (it names ObjectRenderer only), so it is filed rather than edited.

The defect

Both files carry an Exports / Components list for @object-ui/app-shell. objectui#7838 removed ObjectRenderer from it. The three bullets that sat beside it are still there, and each is wrong in a different way — which is exactly why they were not folded into that card:

name measured on the built artifacts at 8507a2283
DashboardRenderer real, wrong package — the only built dist/index.d.ts carrying it is packages/plugin-dashboard/dist/index.d.ts, not app-shell's
PageRenderer on no package's built dist/index.d.ts at all. It exists in source (packages/app-shell/src/views/PageView.tsx, three apps/console/src/sdui-*-preview.tsx) as an internal name reached through the registry, never importable
FormRenderer on no package's built dist/index.d.ts at all; the tracked hits are CHANGELOGs plus one app-shell test

Sites: docs/ARCHITECTURE.md lines 18-20 (the Exports bullets) and 55-57 (the ASCII architecture diagram); docs/CONSOLE-STREAMLINING-SUMMARY.md lines 20-22.

Measured with:

grep -l 'DashboardRenderer' packages/*/dist/index.d.ts   # -> packages/plugin-dashboard/dist/index.d.ts
grep -l 'PageRenderer'      packages/*/dist/index.d.ts   # -> (nothing)
grep -l 'FormRenderer'      packages/*/dist/index.d.ts   # -> (nothing)

For comparison, on the same run grep -c Renderer packages/app-shell/dist/index.d.ts returns 0 — no name containing "Renderer" is on app-shell's built type surface in any spelling.

Why it is a separate card and not a rider on objectui#7838

The ObjectRenderer fix was mechanical because PR objectui#7836 had already measured and landed the replacement spelling for the root README. These three have three different correct answers — move the specifier, delete the bullet as not-an-export, or research what the name became — and picking each one is a judgement call, not a rename. objectui#7095 reached the same split independently from the examples/byo-backend-console/README.md side and wrote it into its suggested-fix section.

Nothing gates it

The repo-root docs/ tree is in no documentation gate's scan surface, so these lines were never judged and will not be. See the sibling finding filed alongside this one for the measured cost of changing that.

Related: objectui#7838 (the ObjectRenderer half, fixed), objectui#7095 (same phantom in examples/byo-backend-console/README.md, still open), objectui#7483 (app-shell's ObjectView props typed any).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationdomain:devxobjectui devx stream: fix lands on .github/, scripts/ or release pipeline — devx lane cross-repo

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions