Skip to content

finding(plugin-markdown): toc-anchor-parity cites packages/react/README.md by line address (:224) and the heading has moved to :253 — a citation nothing checks #7913

Description

@claude

Found while covering packages/react/README.md for #5174 (batch 12, PR #7910). Filed unassigned and NOT fixed there — that card is scoped to the doc-snippet ledger, this is another package's test, and the repair is the one #7853 already named.

What

packages/plugin-markdown/src/toc-anchor-parity.test.tsx:136 names its live instance by line address:

it('resolves the anchor for ### NON_GRID_ROW_CEILING (packages/react/README.md:224)', () => {

That heading is no longer on line 224. PR #7910 adds declare const lines to five earlier blocks in the same README, so ### NON_GRID_ROW_CEILING now sits on line 253. Nothing fails: the test does not read the file, it asserts against an inline '### NON_GRID_ROW_CEILING\n' string, and the address lives only in the test name. That is exactly why it rots silently.

Why file it rather than fix it in #7910

This is the defect class objectui#7853 ruled on and fa7d66c45 landed under — cite the assertion by content, not by line address — and #6998 and #7289 are the same shape in two other files. The repair is one word (drop :224, or cite the heading by its text, which the test already carries). But it is in a different package, it pulls that package's suite into a documentation-ledger diff, and it is not the defect class #5174 is about, so the batch-12 PR deliberately stays at two files.

What a repair looks like

Drop the line address from the test name; the heading text ### NON_GRID_ROW_CEILING is already the identifying content and is already in the assertion one line below. Worth a sweep for other README.md:NNN / .ts:NNN citations in test names at the same time — a line address in a name is checked by nothing, which is the property that makes this class recur.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdomain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatfindingpm:queuepriority:p3tests

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions