You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
finding(test): after objectui#7923's doc fix, object-view-unmirrored-keys-7779.test.ts:514 still cites schema-reference.md as authoring a default: true flag it no longer authors #7992
Finding, created by the fix for objectui#7923 (PR #7991). ⛔ Deliberately NOT fixed there: the file is held by draft PR #7969 (spec seat), and objectui#7923's dispatch excluded it from that card's file surface by name. Unassigned and bare.
packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.ts:514 labels a pair of safeParse measurements with their source:
// schema-reference.md: an ObjectQL tuple filter and a `default: true` flag.consttuple=SpecObjectListViewSchema.safeParse({label: 'My Deals',columns: ['name'],filter: [['owner','=','${currentUser.id}']]});
...
constflagged=SpecObjectListViewSchema.safeParse({label: 'My Deals',columns: ['name'],default: true});
PR #7991 deletes that "default": true from content/docs/api/schema-reference.md's object-view example — it was a key NamedListView never declared and ObjectView never read (objectui#7923). The tuple half of the comment stays true; the flag half does not. After #7991:
the comment claims schema-reference.md authors a default: true flag, and it no longer does — git grep -n '\"default\": true' -- content/docs returns zero hits;
flagged still asserts something real (SpecObjectListViewSchema refuses default), but it is no longer a reading of any shape the docs teach, which is what the surrounding describe presents the block as. The sibling assertion two its below, expect(readRepo('content/docs/api/schema-reference.md')).toContain(...), is the one that keeps its doc side live; this one quietly stops having one.
This is the small end of the objectui#7721 shape: prose inside a pin that states a measurement which has since become false, with nothing holding the prose to the measurement.
Scope, if graded for work
Re-word the comment so it names what flagged actually measures now (the spec refuses default, retained as the reason objectui#7923's doc fix is not merely cosmetic), or
give flagged a live doc side the way its neighbour has one — but note that the doc side deliberately no longer exists, so option 1 is the honest one.
Finding, created by the fix for objectui#7923 (PR #7991). ⛔ Deliberately NOT fixed there: the file is held by draft PR #7969 (spec seat), and objectui#7923's dispatch excluded it from that card's file surface by name. Unassigned and bare.
What is true after #7991 lands
packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.ts:514labels a pair ofsafeParsemeasurements with their source:PR #7991 deletes that
"default": truefromcontent/docs/api/schema-reference.md'sobject-viewexample — it was a keyNamedListViewnever declared andObjectViewnever read (objectui#7923). Thetuplehalf of the comment stays true; the flag half does not. After #7991:schema-reference.mdauthors adefault: trueflag, and it no longer does —git grep -n '\"default\": true' -- content/docsreturns zero hits;flaggedstill asserts something real (SpecObjectListViewSchemarefusesdefault), but it is no longer a reading of any shape the docs teach, which is what the surroundingdescribepresents the block as. The sibling assertion twoits below,expect(readRepo('content/docs/api/schema-reference.md')).toContain(...), is the one that keeps its doc side live; this one quietly stops having one.This is the small end of the objectui#7721 shape: prose inside a pin that states a measurement which has since become false, with nothing holding the prose to the measurement.
Scope, if graded for work
flaggedactually measures now (the spec refusesdefault, retained as the reason objectui#7923's doc fix is not merely cosmetic), orflaggeda live doc side the way its neighbour has one — but note that the doc side deliberately no longer exists, so option 1 is the honest one.object-view-unmirrored-keys-7779.test.tsis currently held by draft PR docs(types): correct the NamedListView member figures and pin the count exactly (objectui#7947) #7969, so whoever takes this should check that PR first — it may already rewrite the block.Related: objectui#7923 (the doc fix that creates this), PR #7991, PR #7969 (holds the file), objectui#7721 (the same shape, on a changeset's prose).
Generated by Claude Code