Skip to content

finding(test): after objectui#7923's doc fix, object-view-unmirrored-keys-7779.test.ts:514 still cites schema-reference.md as authoring a default: true flag it no longer authors #7992

Description

@claude

Finding, created by the fix for objectui#7923 (PR #7991). ⛔ Deliberately NOT fixed there: the file is held by draft PR #7969 (spec seat), and objectui#7923's dispatch excluded it from that card's file surface by name. Unassigned and bare.

What is true after #7991 lands

packages/types/src/__tests__/object-view-unmirrored-keys-7779.test.ts:514 labels a pair of safeParse measurements with their source:

    // schema-reference.md: an ObjectQL tuple filter and a `default: true` flag.
    const tuple = SpecObjectListViewSchema.safeParse({ label: 'My Deals', columns: ['name'], filter: [['owner', '=', '${currentUser.id}']] });
    ...
    const flagged = SpecObjectListViewSchema.safeParse({ label: 'My Deals', columns: ['name'], default: true });

PR #7991 deletes that "default": true from content/docs/api/schema-reference.md's object-view example — it was a key NamedListView never declared and ObjectView never read (objectui#7923). The tuple half of the comment stays true; the flag half does not. After #7991:

  • the comment claims schema-reference.md authors a default: true flag, and it no longer does — git grep -n '\"default\": true' -- content/docs returns zero hits;
  • flagged still asserts something real (SpecObjectListViewSchema refuses default), but it is no longer a reading of any shape the docs teach, which is what the surrounding describe presents the block as. The sibling assertion two its below, expect(readRepo('content/docs/api/schema-reference.md')).toContain(...), is the one that keeps its doc side live; this one quietly stops having one.

This is the small end of the objectui#7721 shape: prose inside a pin that states a measurement which has since become false, with nothing holding the prose to the measurement.

Scope, if graded for work

  1. Re-word the comment so it names what flagged actually measures now (the spec refuses default, retained as the reason objectui#7923's doc fix is not merely cosmetic), or
  2. give flagged a live doc side the way its neighbour has one — but note that the doc side deliberately no longer exists, so option 1 is the honest one.
  3. ⛔ Not urgent and ⛔ not a rider: object-view-unmirrored-keys-7779.test.ts is currently held by draft PR docs(types): correct the NamedListView member figures and pin the count exactly (objectui#7947) #7969, so whoever takes this should check that PR first — it may already rewrite the block.

Related: objectui#7923 (the doc fix that creates this), PR #7991, PR #7969 (holds the file), objectui#7721 (the same shape, on a changeset's prose).


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions