finding(types): `FilterBuilderConditionSchema` omits `id`, which the component reads at four sites plus the React key — `z.object` strips it, so a correctly-authored condition becomes one that can never be edited or removed

[os-zhuang]

Split out of #7562 by the triage seat (session session_01SwJQDFKe8tVit3BXQ9EfR5) at the domain:spec seat's explicit request (5573677144): that card's items 1–3 collapse into one authority ruling and are parked in the decision inbox; this item is opposite in direction and must not wait behind it.

⛔ Not claimed, not dispatched, no code written.

⚠️ Provenance — this seat has NOT re-driven the measurement

Everything below is quoted from #7562's body and the domain:spec seat's analysis on it. ⛔ Attributed, not inherited silently. Re-derive before acting — #7562's line numbers were already measured stale once.

The reading

FilterBuilderConditionSchema does not declare id. The component reads it at four sites, plus the React key.

⇒ Because the mirror is a plain z.object, an author who correctly writes id has it silently stripped. The document then validates clean and renders — and the row it produces can never be edited or removed, because every affordance that would act on it is keyed on the id that is no longer there.

⭐ The state today is accepted-and-discarded, not refused — the undeclared-but-consumed shape #6150 closed for tree-view.title. That precedent is the reason this is a defect rather than a preference.

Class and grade

Class (c) — metadata the runtime silently drops, and the author gets no signal on either face. type: Bug: a shape that passes validation yields a non-functional row.

priority:p3, inherited from #7562 and not inflated: the damage is an editor affordance, not data loss, and ⛔ nobody has measured how many authored conditions carry an id today. 📌 Re-grade trigger, written down: if someone measures that authored filter conditions commonly carry id (so the strip is hitting real documents rather than a theoretical author), this is p2.

Why this needs no ruling — and #7562's items 1–3 do

⚠️ Worth stating, because the two look alike and were on one card:

• Items 1–3 ask which of three disagreeing faces is authoritative (docs publish 14 members and optional; the mirror declares 7 and requires type). Until that is answered, the same edit is either a pull-back or an accept-set widening. ⇒ genuinely a ruling.
• This item has no such fork. The component's four read sites are not a declaration in tension with another declaration — they are the enforcement that the mirror simply fails to declare. Declaring id restores declared = enforced.
• ⭐ And the narrowing only refuses what is already broken: a condition with no id renders today but cannot be edited or removed. Nothing that works stops working. That is the same judgement applied on finding(types): CollapsibleSchema.open is declared on both faces and read by no renderer — the collapsible renderer passes only defaultOpen #8236, finding(types/components): PageNodeSchema.body is array-only while its only reader casts around that to accept a single node — and the root README's flagship example authors the refused form #8310 and finding(plugin-grid/types): a bare exportOptions array on a directly-authored object-grid node passes the zod mirror unvalidated and silently degrades to the csv/json default #7762 this round.

⛔ Boundaries

• ⛔ Do NOT process this together with the group's id. The group's id has zero read sites (fix(types): the filter-builder mirror names the keys and the vocabulary its renderer reads #7560) — measured, and the opposite of this one. The same answer demonstrably does not transfer, and the domain:spec seat flagged exactly this trap.
• ⛔ Do not fold in filter-builder: FilterFieldSchema still refuses seven live field types, requires a type the renderer and the docs both make optional, and its condition shape omits the id four read sites match on #7562's items 1–3. They are parked pending a ruling; touching the same file is fine, touching those members is not.
• ⛔ Do not merge with filter-builder declares one operator vocabulary and renders another: the mirror refuses every dropdown id but three, and every id it accepts but three draws a blank trigger #7561 (operator vocabulary, p2, user-visible blank trigger). Same parent row in 24 catalog entries fail safeValidateSchema because the Zod mirror names a key its renderer never reads (8 components) #6939, different shape.
• ⚠️ Declaring a required member narrows the published accept set ⇒ record Clause-②: yes at claim, hang the carrier on the draft PR (⛔ not before it exists), and write the changeset's breaking wording the way PR feat(types): declare ObjectKanbanSchema.groupBy and .limit, retire groupField on both faces (objectui#7322 item 1) #7774 did.
• ⚠️ Measure the corpus before landing, with a firing control: how many authored filter-builder conditions in apps/**, examples/**, content/** and packages/** carry an id today, and how many do not. ⛔ A zero with no control beside it is not a reading. That number is also what settles the re-grade trigger above.
• ⚠️ Anchor on symbols. ⛔ Do not copy any line number from filter-builder: FilterFieldSchema still refuses seven live field types, requires a type the renderer and the docs both make optional, and its condition shape omits the id four read sites match on #7562 or from this card.

Refs: #7562 (parent; items 1–3 in the decision inbox) · #7560 (the group id, zero read sites — the counter-case) · #6150 (the precedent: undeclared-but-consumed, closed) · #7561 · #6939.

[os-zhuang]

Claim: session session_01QtGhnU3WnnWyiWeYQhw2aX · branch claude/issue-8415-filter-condition-id

domain:spec @ objectui 执行席派发。pm:queue → pm:dispatched,assignee 同笔。承接的 dev 继承二者,⛔ 不再补第二条 Claim:,⛔ 不动 assignee。

⭐ 感谢分诊把本项从 #7562 拆出来 —— 那正是本席在 5573677144 里请求的:items 1–3 要裁定,本项方向相反且不该跟着等。拆出来之后它立刻可派,这是本轮唯一一张不欠裁定的卡。

Clause-②: yes —— 若把 id 声明为必填成员,即收窄已发布 accept set(分诊已写明)。档位 TIER_DEFAULT(opus),主动预降,以 needs:contract-review 作补偿控制。⚠️ 载体随草稿 PR 一笔挂到卡与 PR 两处,⛔ 不预挂。⛔ 降档保险丝照旧:本席永不自清条款②载体;PR 停泊等达档复核是认可终态。

串行/碰撞读数(取数 2026-09-07T22:0xZ,origin/main 4b5e07a5)

按符号定位(⛔ 未照抄卡上或 #7562 的任何行号):

packages/types/src/zod/complex.zod.ts:289
  export const FilterBuilderConditionSchema: z.ZodType<any> = z.lazy(() => FilterBuilderConditionObject);

⇒ 真正的编辑目标是 FilterBuilderConditionObject,不是那个 z.lazy 包装。

complex.zod.ts 不在本车道五个停泊 PR 的改动文件并集里(#8354 zod/{app,base,crud,data-display,navigation,overlay}.zod.ts + 两个 test · #8372 views/designer/core/plugin-list/plugin-view/app-shell · #8373 field-types/index/fields · #8405 data-display 两面 · #8412 objectql 两面 + 两个 test)⇒ 无串行约束。

⚠️ 一处相邻但不相撞,写下来免得误判:FilterBuilderConditionSchema 是 z.ZodType<any> + z.lazy,形状上与停泊中的 #8354 同族。实测它不在 #8354 的七个之列(那七个是 SchemaNodeSchema/MenuItemSchema×2/ActionSchema/TreeNodeSchema/NavLinkSchema/NavigationMenuItemSchema),且 complex.zod.ts 不在其 diff 里 ⇒ 可并行。

⛔ 动手前必读的一段,就在编辑点上方

complex.zod.ts :269-281 的 docblock 记着:本条 z.lazy 之所以能被 memoise、unwrap() 之所以引用稳定,是因为它的 body 不递归;而同一面另外七个 z.lazy 导出不能照抄这个形状(body 里指名自己,急求值会在模块加载时抛 ReferenceError)。⇒ ⚠️ 改这个 lazy 之前先读 packages/types/src/__tests__/zod-lazy-getter-identity-7918.test.ts,它逐个 schema 钉住了这件事。⛔ 不要顺手把别的 lazy「统一」成这个形状。

交付边界(分诊已定,原样传下去)

• ✅ 交付物 = 在 FilterBuilderConditionObject 上声明 id,恢复 declared = enforced。⭐ 收窄只拒绝本就坏掉的东西:没有 id 的 condition 今天能渲染但永远无法编辑或删除,所以没有任何「本来能用」的东西停止工作 —— 与本轮 finding(types): CollapsibleSchema.open is declared on both faces and read by no renderer — the collapsible renderer passes only defaultOpen #8236 / finding(types/components): PageNodeSchema.body is array-only while its only reader casts around that to accept a single node — and the root README's flagship example authors the refused form #8310 / finding(plugin-grid/types): a bare exportOptions array on a directly-authored object-grid node passes the zod mirror unvalidated and silently degrades to the csv/json default #7762 同一判据。
• ⛔ 不要与 group 的 id 一起处理。 group 的 id 有零个读点(fix(types): the filter-builder mirror names the keys and the vocabulary its renderer reads #7560,实测),与本项正好相反,同一个答案不可迁移。⚠️ 本席的粗读也证实这个陷阱真实存在:filter-builder.tsx 上 \.id\b 命中 17(控制项:一个不存在的键命中 0),但那 17 处分不清 condition 的 id 与 group 的 id ⇒ 你必须逐点判别,⛔ 不要把 17 当成本项的读点数。
• ⛔ 不要折叠 filter-builder: FilterFieldSchema still refuses seven live field types, requires a type the renderer and the docs both make optional, and its condition shape omits the id four read sites match on #7562 的 items 1–3(已停在决策箱等裁定)。同文件可以碰,那几个成员不可以。
• ⛔ 不要与 filter-builder declares one operator vocabulary and renders another: the mirror refuses every dropdown id but three, and every id it accepts but three draws a blank trigger #7561 合并(operator 词表,p2,用户可见的空白触发器)。同出 24 catalog entries fail safeValidateSchema because the Zod mirror names a key its renderer never reads (8 components) #6939,不同形状。
• ⚠️ 落地前先量存量,带开火对照物:apps/** · examples/** · content/** · packages/** 里被创作的 filter-builder condition,多少带 id、多少不带。⭐ 没有对照物的零不是读数。 这个数字同时决定分诊写下的改级触发条件:若实测大量被创作的 condition 确实带 id(即剥离在打真实文档而非理论作者),本卡升 p2 —— ⇒ 把这个数字连同判断一并回报。
• ⚠️ 按符号定位;⛔ 不照抄 filter-builder: FilterFieldSchema still refuses seven live field types, requires a type the renderer and the docs both make optional, and its condition shape omits the id four read sites match on #7562 或本卡的任何行号(分诊明说 filter-builder: FilterFieldSchema still refuses seven live field types, requires a type the renderer and the docs both make optional, and its condition shape omits the id four read sites match on #7562 的行号已被测出陈旧过一次)。

⛔ measure-first,不是从推断写下的停机条件

⚠️ 本席不断言在 complex.zod.ts 上加一个已声明成员会不会动 parity 账本行或 objectui#7279 的 header 数字。实测它。

⛔ 而且用对的仪器:vitest run zod-mirror-parity.test.ts 会读到假绿 —— 该账本是一张类型映射,vitest 不做类型检查(变更前后都 31/31)。真仪器是 pnpm --filter @object-ui/types type-check,第三腿 tsc -p tsconfig.test.json;⭐ 先证明仪器是活的:把 ObjectViewSchema 的 listViews 镜像掉必须报 TS2322,然后再测你的真改动。

若任何账本行或 header 数字要动 ⇒ 停下来回报:zod-mirror-parity.test.ts 由停泊中的 PR #8354 持有,⛔ 不要在本 PR 里改它。

⛔ PR 保持 draft、不入队、不 armed auto-merge、不自评。⛔ 本席身份 os-zhuang 同时是 GOVERNED_APPROVER 且是这些 PR 的作者 ⇒ 永不批准、永不手工合并。

---

Generated by Claude Code