[FIX] hr_holidays: fix traceback on time off type#5174
Open
manalelk wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-maelk, it needs to be retargeted before it can be merged. |
manalelk
force-pushed
the
master-hr-onboarding-traceback_on_time_off_type-maelk
branch
3 times, most recently
from
daff310 to
262fce3
Compare
arpi-odoo
requested changes
Jun 9, 2026
arpi-odoo
left a comment
arpi-odoo
left a comment
There was a problem hiding this comment.
In the commit message and PR description, the last step of "steps to reproduce" should be a short description of the traceback/error that you should get by following the steps.
Otherwise, code-wise, everything looks good to me ! Nice work !
manalelk
force-pushed
the
master-hr-onboarding-traceback_on_time_off_type-maelk
branch
from
262fce3 to
940ae93
Compare
There was an error when selecting a Time Off Type with existing allocations. Step to reproduce: - Create and validate an allocation for a Time Off Type that requires allocations - Open this Time Off Type and create a new Time Off request from the smart button - In the creation popup, click on the 'Time off Type' field - A traceback is raised: TypeError: gt expected 2 arguments, got 1 Reason: The search method for virtual_remaining_leaves was missing a required parameter Solution: Pass the missing value parameter when calling op() Task-6276095
manalelk
force-pushed
the
master-hr-onboarding-traceback_on_time_off_type-maelk
branch
from
940ae93 to
8d817bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an error when selecting a Time Off Type with existing allocations.
Step to reproduce:
Reason:
The search method for virtual_remaining_leaves was missing a required parameter
Solution:
Pass the missing value parameter when calling op()
Task-6276095