diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c7121f7..08365db 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,30 +17,9 @@ jobs: - run: make ci-web - cargo-check: - name: Rust compile check - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Install Linux dependencies - run: | - sudo apt-get update - sudo apt-get install -y libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf - - - uses: dtolnay/rust-toolchain@stable - - - uses: Swatinem/rust-cache@v2 - with: - workspaces: packages/desktop/src-tauri -> target - - - uses: ./.github/actions/setup - - - run: make ci-desktop - release: name: Release - needs: [check, cargo-check] + needs: [check] if: github.event_name == 'push' && github.ref == 'refs/heads/main' runs-on: ubuntu-latest permissions: diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 0000000..72ec0fd --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,16 @@ +# openconcho Agent Notes + +## CI policy + +- PR CI only runs the web checks. +- Rust/Tauri compile-check is local-only for now because the Linux dependency setup on GitHub Actions is too slow for routine PR validation. + +## Required local preflight + +- Before pushing any change under `packages/desktop/**` or `packages/desktop/src-tauri/**`, run: + - `pnpm --filter @openconcho/desktop cargo-check` + +## Useful commands + +- `make ci-web` — matches current PR CI +- `pnpm --filter @openconcho/desktop cargo-check` — local desktop compile check diff --git a/CLAUDE.md b/CLAUDE.md index d647c4c..0ea8d5f 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -17,6 +17,7 @@ Frontend UI for self-hosted Honcho instances — browse memories, peers, session | `make test` | Vitest (unit + integration), excludes `e2e/` | | `make test-e2e` | Playwright e2e (uncached) | | `make check` | lint + typecheck + test | +| `pnpm --filter @openconcho/desktop cargo-check` | Local Rust/Tauri compile check before pushing desktop changes | | `pnpm --filter @openconcho/web generate:api` | Regen `src/api/schema.d.ts` from `openapi.json` | ## Structure @@ -58,3 +59,4 @@ Read `docs/architecture.md` for component overview, data flow, and design decisi - **Conventional commits enforced** — commitlint runs in husky `commit-msg`; body lines must be ≤100 chars - **Releases via semantic-release** — `.releaserc.json`; commits land on `main`, no manual version bumps - **GitHub account** — push under `offendingcommit` (`gh auth switch` if needed) +- **Desktop preflight is local** — Rust/Tauri compile-check no longer runs in PR CI; run `pnpm --filter @openconcho/desktop cargo-check` before pushing any `packages/desktop/**` or `packages/desktop/src-tauri/**` change diff --git a/packages/web/src/components/conclusions/ConclusionBrowser.tsx b/packages/web/src/components/conclusions/ConclusionBrowser.tsx index 2cd756f..347ab55 100644 --- a/packages/web/src/components/conclusions/ConclusionBrowser.tsx +++ b/packages/web/src/components/conclusions/ConclusionBrowser.tsx @@ -14,8 +14,8 @@ import { ConfirmDialog } from "@/components/shared/ConfirmDialog"; import { EmptyState } from "@/components/shared/EmptyState"; import { ErrorAlert } from "@/components/shared/ErrorAlert"; import { FormModal } from "@/components/shared/FormModal"; -import { PageLoader } from "@/components/shared/LoadingSpinner"; import { Pagination } from "@/components/shared/Pagination"; +import { Skeleton } from "@/components/shared/Skeleton"; import { SortControl, type SortDir } from "@/components/shared/SortControl"; import { TimestampChip } from "@/components/shared/TimestampChip"; import { Button } from "@/components/ui/button"; @@ -193,7 +193,7 @@ export function ConclusionBrowser() { - {(isLoading || (activeSearch && searchLoading)) && } + {(isLoading || (activeSearch && searchLoading)) && } {!isLoading && !searchLoading && displayedConclusions.length === 0 && (