From b71da050aefb8b6a4bafd25ddf7f2041cb7de968 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Fri, 23 Oct 2026 13:57:08 -0700 Subject: [PATCH] test: preserve nested JSON in snapshot privacy checks --- CHANGELOG.md | 2 ++ internal/cli/cloud_snapshot_test.go | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a0552996..660d2652 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +- Keep the cloud snapshot privacy regression compatible with SQLite 3.53 and 3.54 by explicitly preserving nested JSON arrays across subqueries. + - Update the pinned TruffleHog secret-scanning action to v3.99.3. Thanks @dependabot. - Request `synchronous=FULL` on every SQLite connection and, on macOS, `fullfsync` for commits and checkpoints. Go test binaries skip the macOS full flush. - Let the native code producer publish from a captured upstream commit when core progress is fresh, even while provider coverage is incomplete. Retries and coverage are not changed. diff --git a/internal/cli/cloud_snapshot_test.go b/internal/cli/cloud_snapshot_test.go index 5858309f..d8aedc7b 100644 --- a/internal/cli/cloud_snapshot_test.go +++ b/internal/cli/cloud_snapshot_test.go @@ -216,7 +216,7 @@ func TestCloudSQLiteSnapshotLegacyPrivacyColumns(t *testing.T) { create table sync_attempt_failures(error_message text); insert into sync_attempt_failures values('private');`, query: `select json_array( - (select json_group_array(raw_json) from comment_revisions), + json((select json_group_array(raw_json) from comment_revisions)), (select raw_json from pull_request_review_thread_revisions), (select error_message from sync_attempt_failures))`, want: `[[null,"",""],"",""]`,