Run Hermes adapter through local harness - #35
Conversation
|
Codex review: needs changes before merge. Reviewed August 3, 2026, 5:05 AM ET / 09:05 UTC. ClawSweeper reviewWhat this changesThe branch routes registered local adapters through ShellBench’s generic execution lifecycle, configures Hermes from environment variables, and adds workspace guidance to Hermes prompts. Merge readinessKeep this PR open: current Priority: P2 Review scores
Verification
How this fits togetherShellBench’s harness selects an adapter, runs benchmark task phases in a task workspace, then scores files, execution results, and agent state. Hermes is a local agent adapter whose post-run state must be verified through its adapter-specific implementation rather than the OpenClaw gateway. flowchart LR
Tasks[Benchmark tasks] --> Harness[Benchmark harness]
Harness --> Adapter[Hermes adapter]
Adapter --> Workspace[Task workspace]
Adapter --> State[Adapter state verifier]
Workspace --> Scoring[Completion scorer]
State --> Scoring
Scoring --> Results[Benchmark results]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Score local adapter runs while the live adapter context is available, passing state assertions through the adapter’s verifier and preserving OpenClaw’s existing gateway-based scoring path. Do we have a high-confidence way to reproduce the issue? Yes—source inspection gives a high-confidence path: select Hermes Is this the best way to solve the issue? No—the generic adapter lifecycle is the right direction, but scoring after teardown with a gateway-only client is not the narrowest correct integration; state verification must use the live adapter context. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (30 earlier review cycles; latest 8 shown)
|
Summary
Validation
/Users/reckon/miniconda3/bin/python -m pytest tests/test_harness.py tests/test_hermes_adapter.py -q->21 passed/Users/reckon/miniconda3/bin/python -m pytest -q->318 passed, 5 skippedt2-msg-summarize-threadimproved from0.63704to1.000with the workspace-guidance patch.Notes
adapter != "openclaw"through the adapter lifecycle.