fix: accept Claude native trajectories - #52
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 3, 2026, 5:05 AM ET / 09:05 UTC. ClawSweeper reviewWhat this changesAdds Merge readinessCurrent Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native runner records each harness run in a manifest and converts agent output into a standardized trajectory. Aggregation consumes the manifest mode and per-task trajectory status to decide whether a completed run is eligible for native benchmark results. flowchart LR
A[Claude Code stream output] --> B[Native trajectory conversion]
B --> C[Run manifest trajectory mode]
C --> D[Aggregate eligibility check]
D --> E[Native benchmark result]
Decision needed
Why: The code path and test establish a narrow consistency repair, but accepting a harness into the real-evidence category changes benchmark eligibility policy rather than only correcting presentation. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm that Claude Code’s standardized stream events meet the same evidence contract as the other native harnesses, then merge this narrow allowlist repair with its contract test. Do we have a high-confidence way to reproduce the issue? Yes, from current source: a Claude Code run is converted to a real trajectory, but its manifest is marked unsupported and aggregation consequently selects Is this the best way to solve the issue? Yes mechanically: adding the already-pinned harness to the existing allowlist is the narrowest repair and the new contract test covers the registry boundary. Maintainer confirmation is still needed because the classification controls benchmark eligibility. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (19 earlier review cycles; latest 8 shown)
|
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally