fix: apply native reasoning effort to harnesses - #54
Conversation
|
Codex review: needs maintainer review before merge. Reviewed August 3, 2026, 5:05 AM ET / 09:05 UTC. ClawSweeper reviewWhat this changesThe PR carries each planned run’s reasoning effort through Merge readinessThis member-authored PR addresses a current and material native-evaluation consistency defect: current Priority: P1 Review scores
Verification
How this fits togetherShellBench builds a native evaluation plan, dispatches each run through the fleet, and generates one command/configuration per harness. Those clients send benchmark prompts through the proxy, while the run manifest records the intended execution settings used to interpret quality, token, and latency comparisons. flowchart LR
A[Evaluation plan] --> B[Fleet dispatch]
B --> C[Run environment]
C --> D[Run specification]
D --> E[Native harness command]
E --> F[OpenClaw Hermes Codex Claude Code]
F --> G[Proxy and benchmark results]
D --> H[Run manifest]
Decision needed
Why: Command-construction tests establish the repository wiring, but only a real run can confirm that each pinned external client accepts and honors the emitted control rather than rejecting it or silently using a different setting. Before merge
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Land the focused propagation after a redacted smoke run verifies that each pinned harness accepts its mapped effort setting and that the resulting metadata reflects the requested value; preserve the current no-effort defaults and clearly separate pre-fix benchmark data from newly controlled runs. Do we have a high-confidence way to reproduce the issue? Yes—source establishes the mismatch on current Is this the best way to solve the issue? Yes—the branch uses the existing plan, fleet environment, run specification, and harness adapters rather than introducing a parallel configuration path. A short pinned-client smoke run is the remaining prudent validation for the external command contracts. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (25 earlier review cycles; latest 8 shown)
|
What does this PR do?
Propagates the native eval plan's reasoning effort into OpenClaw, Hermes,
Codex, and Claude Code client controls.
Why?
Fixes #53. Without this, a run can be labeled
highwhile OpenClaw executeswith thinking disabled, invalidating cross-harness quality and efficiency
comparisons.
Changes
reasoning_effortinRunSpecand the run manifestxhighto Claude Code'smaxlow,medium,high, andxhighacross all four harnessesTests