feat(native-eval): export tool discovery telemetry - #60
Conversation
|
Codex review: found issues before merge. Reviewed August 3, 2026, 12:10 AM ET / 04:10 UTC. ClawSweeper reviewWhat this changesThe branch adds normalized OpenClaw tool-discovery telemetry, trace-fidelity and runner provenance fields, a new Merge readinessKeep this member-authored PR open: current Priority: P3 Review scores
Verification
How this fits togetherShellBench’s native-evaluation research audit converts extracted benchmark traces and run manifests into CSV tables used to validate model identity, tools, usage, and campaign provenance. This change adds discovery-operation evidence so cross-harness analysis can distinguish observed zero use from unsupported or unobservable discovery events. flowchart LR
A[Run manifests] --> C[Research audit exporter]
B[Extracted task traces] --> C
C --> D[Discovery telemetry parser]
D --> E[Normalized discovery events]
C --> F[Trace inventory]
E --> G[Research CSV directory]
F --> G
G --> H[Campaign analysis and audit]
Decision needed
Why: This PR expands the normative campaign output contract rather than repairing an established broken export, and the linked feature request is explicitly awaiting product-direction review. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm that normalized discovery telemetry belongs in the campaign’s durable research schema, then add Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: source inspection confirms that current main emits only the existing four CSV audit tables, while the branch adds a distinct fifth artifact. The branch’s test coverage exercises synthetic exports, but no additional live failure reproduction is needed to establish the documentation-contract gap. Is this the best way to solve the issue? No—not yet. The parser and normalization approach is focused, but adding a durable campaign artifact without updating the normative runbook and confirming the research-schema direction leaves the solution incomplete. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (23 earlier review cycles; latest 8 shown)
|
What does this PR do?
Exports native-harness tool discovery operations separately from final tool
calls and records the trace fidelity needed to interpret missing events.
Why?
Fixes #59.
The existing research audit records
tool_search_codeas one wrapper call butdrops OpenClaw's embedded catalog and search/describe/call counters. It also
cannot distinguish disabled discovery from unsupported or unobservable native
events, which makes cross-harness comparisons produce fake zeros.
Changes
discovery_events.csvwith normalized search, describe, and call countsTests
python -m pytest -q tests/test_native_eval_research_audit.pypython -m ruff check scripts/native_eval/research_audit.py tests/test_native_eval_research_audit.pyall three tasks report the expected runner SHA, session fidelity,
disableddiscovery state, and zero discovery operations