From c4f2bb97103f657b5ec0a37214ac9982e49475cd Mon Sep 17 00:00:00 2001 From: Maxim Patlasov Date: Fri, 21 Aug 2026 14:44:37 -0700 Subject: [PATCH] Fix upgrade-check-dev-symlinks jobs All upgrade-check-dev-symlinks jobs saves data before upgrade by storage-disk-symlinks-save-commands.sh then checks the data after upgrade by storage-disk-symlinks-check-commands.sh. On rare occasions, `oc get nodes` before upgrade may return reduced list, then, after upgrade, a node from new invocation of `oc get nodes` won't have info from save step. This commit adds "skip" clause for such nodes because the goal of upgrade-check-dev-symlinks jobs is to compare data before-vs-after upgrade, not making sure the list of nodes is the same on all runs. --- .../check/storage-disk-symlinks-check-commands.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ci-operator/step-registry/storage/disk-symlinks/check/storage-disk-symlinks-check-commands.sh b/ci-operator/step-registry/storage/disk-symlinks/check/storage-disk-symlinks-check-commands.sh index f6f8bd1c1537e..89c70dd86ba77 100755 --- a/ci-operator/step-registry/storage/disk-symlinks/check/storage-disk-symlinks-check-commands.sh +++ b/ci-operator/step-registry/storage/disk-symlinks/check/storage-disk-symlinks-check-commands.sh @@ -10,6 +10,11 @@ for NODE in `oc -o custom-columns=NAME:.metadata.name get nodes --no-headers`; d ROOT_DISK=$(oc debug --quiet --to-namespace default node/$NODE -- chroot /host /usr/bin/bash -c "findmnt -o SOURCE --noheadings --nofsroot --mountpoint /sysroot") if [ -z $ROOT_DISK ]; then echo "root disk not found"; exit 1; fi echo "ROOT_DISK $ROOT_DISK" + + if [ ! -f $OUT ]; then + echo "Skip $NODE because it was absent on storage-disk-symlinks-save step" + continue + fi cat $OUT SUCCESS="yes"