From 1f3451ebdb3314e0eb14da3093442f7d65b123b6 Mon Sep 17 00:00:00 2001
From: bigboateng <bigboateng2011@gmail.com>
Date: Tue, 11 Aug 2026 09:44:15 +0100
Subject: [PATCH] Verify repacked Go mirror metadata

---
 packaging/private-mirror.mjs      | 19 +++++++++----
 packaging/private-mirror.test.mjs | 46 +++++++++++++++++++++++++++++++
 2 files changed, 60 insertions(+), 5 deletions(-)

diff --git a/packaging/private-mirror.mjs b/packaging/private-mirror.mjs
index aa84bc8..74894f0 100644
--- a/packaging/private-mirror.mjs
+++ b/packaging/private-mirror.mjs
@@ -170,12 +170,21 @@ async function remoteGo(manifest, base, fetchImpl) {
   if (response.status === 404) return []
   expect(response.ok, `private Go proxy returned HTTP ${response.status}`)
   const privateDigest = await responseSHA256(response)
-  const publicResponse = await fetchImpl(
-    `https://proxy.golang.org/github.com/operatorstack/yield/@v/v${manifest.version}.zip`,
-    { cache: "no-store" },
+  const modulePath = `github.com/operatorstack/yield/@v/v${manifest.version}.mod`
+  const [privateModule, publicModule] = await Promise.all([
+    fetchImpl(`${base}/go/${modulePath}`, { cache: "no-store" }),
+    fetchImpl(`https://proxy.golang.org/${modulePath}`, { cache: "no-store" }),
+  ])
+  expect(privateModule.ok, `private Go module metadata returned HTTP ${privateModule.status}`)
+  expect(publicModule.ok, `public Go module metadata returned HTTP ${publicModule.status}`)
+  const [privateModuleBytes, publicModuleBytes] = await Promise.all([
+    privateModule.arrayBuffer(),
+    publicModule.arrayBuffer(),
+  ])
+  expect(
+    Buffer.from(privateModuleBytes).equals(Buffer.from(publicModuleBytes)),
+    "private Go module metadata differs from the public module",
   )
-  const publicDigest = await responseSHA256(publicResponse)
-  expect(privateDigest === publicDigest, "private Go module zip differs from the public module")
   return [{ name: manifest.go.module, sha256: privateDigest }]
 }
 
diff --git a/packaging/private-mirror.test.mjs b/packaging/private-mirror.test.mjs
index aa3ed00..6464e72 100644
--- a/packaging/private-mirror.test.mjs
+++ b/packaging/private-mirror.test.mjs
@@ -59,3 +59,49 @@ test("treats a missing private crate payload as recoverable", async () => {
   assert.equal(result.states.rust, "missing")
   assert.deepEqual(result.missing.rust, manifest.rust)
 })
+
+test("accepts a Go proxy repack while requiring identical module metadata", async () => {
+  const manifest = {
+    version: "0.5.2",
+    npm: [],
+    python: [],
+    go: { module: "github.com/operatorstack/yield", version: "v0.5.2" },
+    rust: [],
+  }
+  const fetchImpl = async (url) => {
+    const value = String(url)
+    if (value.includes("/pip/simple/")) return new Response("missing", { status: 404 })
+    if (value.endsWith(".mod")) return new Response("module github.com/operatorstack/yield\n")
+    if (value.includes("/go/") && value.endsWith(".zip"))
+      return new Response("artifact-registry-repacked-zip")
+    throw new Error(`unexpected request ${value}`)
+  }
+
+  const result = await inspectRemote(manifest, { base: "https://mirror.test", fetchImpl })
+  assert.equal(result.states.go, "matched")
+  assert.equal(result.remote.go[0].name, manifest.go.module)
+  assert.match(result.remote.go[0].sha256, /^[0-9a-f]{64}$/)
+})
+
+test("refuses Go proxy metadata drift", async () => {
+  const manifest = {
+    version: "0.5.2",
+    npm: [],
+    python: [],
+    go: { module: "github.com/operatorstack/yield", version: "v0.5.2" },
+    rust: [],
+  }
+  const fetchImpl = async (url) => {
+    const value = String(url)
+    if (value.includes("/pip/simple/")) return new Response("missing", { status: 404 })
+    if (value.endsWith(".zip")) return new Response("private-zip")
+    if (value.startsWith("https://proxy.golang.org/")) return new Response("module public\n")
+    if (value.endsWith(".mod")) return new Response("module private\n")
+    throw new Error(`unexpected request ${value}`)
+  }
+
+  await assert.rejects(
+    inspectRemote(manifest, { base: "https://mirror.test", fetchImpl }),
+    /private Go module metadata differs/,
+  )
+})