Skip to content

fix: user sync to ingestor#1638

Merged
nitisht merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix/user-sync
May 3, 2026
Merged

fix: user sync to ingestor#1638
nitisht merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix/user-sync

Conversation

@nikhilsinhaparseable
Copy link
Copy Markdown
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented May 3, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed tenant validation in user management operations. Non-administrative users can now only perform actions within their authorized tenant, improving access control enforcement.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cdc51ccf-f2f9-4a9c-b3c8-b7eb3b0ad82b

📥 Commits

Reviewing files that changed from the base of the PR and between fddd254 and ec312ff.

📒 Files selected for processing (1)
  • src/handlers/http/modal/ingest/ingestor_rbac.rs

Walkthrough

A single-line tenant-validation logic fix in the RBAC handler. The condition in post_user is inverted from eq to ne, correcting the check so non-super-admin users are now rejected when their tenant does not match the target user's tenant.

Changes

Tenant RBAC Validation Fix

Layer / File(s) Summary
RBAC Guard Logic
src/handlers/http/modal/ingest/ingestor_rbac.rs
Line 52: Tenant mismatch condition inverted from eq to ne. Non-super-admin requests are now correctly rejected when the requesting tenant does not match the target user's tenant.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A logic flip, so small yet true,
From "equal" turned to "not", anew!
Tenants now stay in their rightful place,
No cross-border mishaps to embrace. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided, failing to meet the repository's required template which expects context about the fix, rationale, and testing/documentation checklist. Add a comprehensive description following the template: explain what issue is being fixed (reference issue #XXXX), describe the bug and solution, list key changes, and complete the testing and documentation checklist.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix: user sync to ingestor' is vague and lacks specificity about the actual bug fix involving the tenant-validation condition inversion in the post_user handler. Provide a more specific title that clearly describes the bug being fixed, such as 'fix: correct tenant validation logic in post_user handler' to better convey the actual change.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@nitisht nitisht merged commit 943a402 into parseablehq:main May 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants