From ecc8fb5c0f37593d25ca792753fbd817a31a76a9 Mon Sep 17 00:00:00 2001
From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Date: Mon, 13 Jul 2026 14:47:42 +0000
Subject: [PATCH 1/2] =?UTF-8?q?feat:=20implement=20issue=20#701=20?=
 =?UTF-8?q?=E2=80=94=20Canary=20blocker:=20add-to-project=20next->ring0=20?=
 =?UTF-8?q?(cum=5Ffail=3D1,=20PRE=5FEXISTING)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 standards/canary-rings.json |  9 ++++++++-
 tests/canary_rollout.bats   | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 1 deletion(-)

diff --git a/standards/canary-rings.json b/standards/canary-rings.json
index e98de3ec..c438b11b 100644
--- a/standards/canary-rings.json
+++ b/standards/canary-rings.json
@@ -838,7 +838,14 @@
         "_standard": "petry-projects/.github#548 \u2014 graduated dwell/sample gate over a per-candidate cumulative window. These are registry-configurable per-transition knobs; the values below are the #548 defaults.",
         "baseline_window_days": 14,
         "baseline_spike_cap_multiple": 3,
-        "benign_failure_classes": [],
+        "benign_failure_classes": [
+          {
+            "id": "reusable-setup-restricted-secrets",
+            "workflow": "Auto-add to Initiatives project",
+            "step": "Set up job",
+            "reason": "#701/#668 \u2014 the caller (Auto-add to Initiatives project) triggers on pull_request_target/issues and passes required INITIATIVES_APP_* secrets to the called reusable; in a restricted-secret context (e.g. a Dependabot-authored event) GitHub withholds those Actions secrets, so the called workflow fails at 'Set up job' at startup, before any candidate reusable step runs. Environmental/pre-existing, not a candidate regression. NOT version_independent: a 'Set up job' signature could also arise from a candidate breaking the reusable's own YAML, so this excludes only at differs=0 (byte-identical) and can never mask a differs=1 regression."
+          }
+        ],
         "control": {
           "allow_pre_existing": false
         },
diff --git a/tests/canary_rollout.bats b/tests/canary_rollout.bats
index aa9bbca6..55e67df3 100644
--- a/tests/canary_rollout.bats
+++ b/tests/canary_rollout.bats
@@ -1411,6 +1411,40 @@ GITEOF
   [ "$status" -eq 0 ]
 }
 
+@test "canary-rings.json: add-to-project gate carries a 'Set up job' startup benign class (#701)" {
+  # #701 fix-forward: a pre-existing/environmental 'Set up job' startup failure of the
+  # add-to-project reusable was counted in cum_fail and blocked the next->ring0 gate.
+  run jq -e '.agents["add-to-project"].gate.benign_failure_classes
+             | type == "array" and length >= 1' "$RINGS"
+  [ "$status" -eq 0 ]
+  run jq -e '.agents["add-to-project"].gate.benign_failure_classes[]
+             | select(.id=="reusable-setup-restricted-secrets")
+             | has("id") and has("reason") and has("step") and has("workflow")' "$RINGS"
+  [ "$status" -eq 0 ]
+}
+
+@test "canary-rings.json: add-to-project benign class matches a 'Set up job' failure of its caller workflow (#701)" {
+  # Functional: drive benign_match with the class's own workflow+step regex.
+  wf_re="$(jq -r '.agents["add-to-project"].gate.benign_failure_classes[]
+                  | select(.id=="reusable-setup-restricted-secrets") | .workflow' "$RINGS")"
+  step_re="$(jq -r '.agents["add-to-project"].gate.benign_failure_classes[]
+                    | select(.id=="reusable-setup-restricted-secrets") | .step' "$RINGS")"
+  [ "$(benign_match 'Auto-add to Initiatives project' 'Set up job' "$wf_re" "$step_re")" = "yes" ]
+  # a normal in-reusable step failure of the same workflow is NOT swept up by this class
+  [ "$(benign_match 'Auto-add to Initiatives project' 'Add issue to project' "$wf_re" "$step_re")" = "no" ]
+  # and it does not leak onto an unrelated workflow
+  [ "$(benign_match 'Dev-Lead Agent' 'Set up job' "$wf_re" "$step_re")" = "no" ]
+}
+
+@test "canary-rings.json: add-to-project 'Set up job' class is NOT version_independent (can't mask a differs=1 regression) (#701)" {
+  # A 'Set up job' signature could also arise from a candidate breaking the reusable's own
+  # YAML, so the class must stay inert at differs=1 (excludes only when byte-identical).
+  run jq -e '.agents["add-to-project"].gate.benign_failure_classes[]
+             | select(.id=="reusable-setup-restricted-secrets")
+             | has("version_independent") | not' "$RINGS"
+  [ "$status" -eq 0 ]
+}
+
 # ── SUSPECT triage: suspect_failure_classes (#668 increment 2, #675) ─────────────
 # A *possibly-candidate-caused* failure class (dev-lead exit-124 workload timeouts) gets
 # the full REGRESSION verdict at differs=1 today, forcing ad-hoc human diagnosis each time.

From 2d001e89e1c2cfb283ea9025d7694ad8338ccb39 Mon Sep 17 00:00:00 2001
From: donpetry-bot <281750570+donpetry-bot@users.noreply.github.com>
Date: Mon, 13 Jul 2026 14:57:53 +0000
Subject: [PATCH 2/2] fix(reviews): address review comments [skip ci-relay]

---
 tests/canary_rollout.bats | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/canary_rollout.bats b/tests/canary_rollout.bats
index 55e67df3..75b5b901 100644
--- a/tests/canary_rollout.bats
+++ b/tests/canary_rollout.bats
@@ -1441,7 +1441,7 @@ GITEOF
   # YAML, so the class must stay inert at differs=1 (excludes only when byte-identical).
   run jq -e '.agents["add-to-project"].gate.benign_failure_classes[]
              | select(.id=="reusable-setup-restricted-secrets")
-             | has("version_independent") | not' "$RINGS"
+             | .version_independent != true' "$RINGS"
   [ "$status" -eq 0 ]
 }