Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions integration/pgdog.toml
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,13 @@ name = "sharded_list_uuid"
column = "id_uuid"
data_type = "uuid"

[[sharded_tables]]
database = "pgdog_sharded"
name = "hits"
column = "userid"
data_type = "bigint"
primary = true

[[sharded_mappings]]
database = "pgdog_sharded"
table = "sharded_list_uuid"
Expand Down
6 changes: 6 additions & 0 deletions integration/sql/cases/942_clickbench_q03_case.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
-- description: ClickBench Citus query 3
-- tags: sharded
-- transactional: true
-- only-targets: postgres_standard_text pgdog_sharded_text pgdog_sharded_binary

SELECT SUM(AdvEngineID), COUNT(*), AVG(ResolutionWidth) FROM hits;
1 change: 1 addition & 0 deletions integration/sql/cases/942_clickbench_q03_setup.sql
1 change: 1 addition & 0 deletions integration/sql/cases/942_clickbench_q03_teardown.sql
123 changes: 123 additions & 0 deletions integration/sql/cases/clickbench_setup.sql

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions integration/sql/cases/clickbench_teardown.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
DROP TABLE IF EXISTS hits;
12 changes: 7 additions & 5 deletions pgdog/src/backend/pool/connection/aggregate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -612,8 +612,8 @@ fn multiply_for_average(value: &Datum, count: &Datum) -> Option<Datum> {
Some(Datum::Float(Float((float.0 as f64 * multiplier) as f32)))
}
Datum::Numeric(numeric) => {
let decimal = numeric.as_decimal()?.to_owned();
let product = decimal * Decimal::from_i128_with_scale(multiplier_i128, 0);
let decimal = numeric.as_decimal()?;
let product = decimal * Decimal::from_i128(multiplier_i128)?;
Some(Datum::Numeric(Numeric::from(product)))
}
_ => None,
Expand All @@ -636,12 +636,14 @@ fn divide_for_average(sum: &Datum, count: &Datum) -> Option<Datum> {
(float.0 as f64 / divisor_i128 as f64) as f32,
))),
Datum::Numeric(numeric) => {
let decimal = numeric.as_decimal()?.to_owned();
let divisor = Decimal::from_i128_with_scale(divisor_i128, 0);
let decimal = numeric.as_decimal()?;
let divisor = Decimal::from_i128(divisor_i128)?;
if divisor == Decimal::ZERO {
Some(Datum::Null)
} else {
Some(Datum::Numeric(Numeric::from(decimal / divisor)))
let mut result = decimal / divisor;
result.rescale(decimal.scale());
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the relevant change. Everything else is light cleanup

Some(Datum::Numeric(Numeric::new(result)))
}
}
_ => None,
Expand Down
Loading