Skip to content

Shell::windows? function should include check for mingw #19

Description

@mwolfe38

Recently the installer for ruby 1.9.1 was changed such that the binaries are compiled with mingw rather than the mswin compiler that was used before.. This changes the platform string such that there is no mswin portion anymore and makes your windows check invalid.
Thus, if you could change it as follows:

def windows?
RUBY_PLATFORM =~ /mswin|mingw/
end

It will fix lots of issues that are sure to happen as more people begin installing the newly compiled windows version

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions