Skip to content

CI: check the EN-Revision hash of changed files#1513

Merged
saundefined merged 1 commit into
php:masterfrom
lacatoire:ci/check-en-revision
Jul 8, 2026
Merged

CI: check the EN-Revision hash of changed files#1513
saundefined merged 1 commit into
php:masterfrom
lacatoire:ci/check-en-revision

Conversation

@lacatoire

@lacatoire lacatoire commented Jul 7, 2026

Copy link
Copy Markdown
Member

Adds a workflow that, on every PR, checks that the EN-Revision: comment of the changed .xml files points to the latest doc-en commit for that file. A missing, wrong, mismatched or outdated hash produces a ::error annotation.

The same check already runs on php/doc-fr (on every PR) and php/doc-es:
https://github.com/php/doc-fr/blob/master/.github/workflows/check-en-revision.yml

It only needs a checkout of doc-en, no doc-base. To make it warn without blocking the PR, change the final exit $fail to exit 0.

A shared translation toolchain is being built in php/doc-base so every language can get these checks from a single place. Until that lands, this workflow is a useful stopgap: it is fully self-contained (doc-en checkout only) and provides the check today.

@lacatoire
lacatoire requested a review from a team as a code owner July 7, 2026 13:21
@lacatoire
lacatoire force-pushed the ci/check-en-revision branch from 37847cf to 7dbd9d1 Compare July 7, 2026 13:32
@lacatoire lacatoire changed the title CI: проверка хеша EN-Revision в изменённых файлах CI: check the EN-Revision hash of changed files Jul 7, 2026
@alfsb

alfsb commented Jul 7, 2026

Copy link
Copy Markdown
Member

Sorry. Commented on the wrong PR.

@saundefined
saundefined merged commit b19cd97 into php:master Jul 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants