Repository navigation
Conversation
Girgias
reviewed
Dec 4, 2025
This redifines start_now param to start_mode in php_dl / php_load_extension to allow selection of start hooks to run. And for php-fpm it uses just starting of module.
bukka
force-pushed
the
fpm_gh19520_ext_dl_init
branch
from
October 27, 2026 19:24
446ea62 to
7783a8d
Compare
bukka
marked this pull request as ready for review
October 27, 2026 19:26
Member
Author
|
I have done more testing and also did some changes to make it a bit more backward compatible so it should be now safe for bug fix version. Targeting 8.5 as 8.4 is soon in security support and it should be even more risky if targeting just 8.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This redifines start_now param to start_mode in php_dl / php_load_extension to allow selection of start hooks to run. And for php-fpm it uses just starting of module.