Repository navigation
Conversation
Member
|
Hey, thanks for the PR. |
_php_setup_easy_copy_handlers() copies the write, read and write_header streams but not std_err. The clone never checks that stream is still open, so libcurl keeps writing to a FILE* freed when the stream is closed. Copy std_err like the other handlers.
lacatoire
force-pushed
the
fix/curl-copy-handle-stderr-upstream
branch
from
October 26, 2026 07:48
08b5827 to
e421f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_php_setup_easy_copy_handlers()copies thewrite,readandwrite_headerstreams but notstd_err. The clone never checks that the stream is still open, so libcurl keeps writing to aFILE*freed when the stream is closed.Copy
std_errlike the other handlers.