Repository navigation
Conversation
… symlinks On Solaris/illumos /proc/self/fd entries are not symlinks, so readlink() fails with EINVAL. Co-authored-by: David Carlier <devnexen@gmail.com>
jorgsowa
changed the title
LamentXU123
approved these changes
Oct 23, 2026
Contributor
Author
|
Solaris job didn't run, I cannot verify the branch properly this way. |
Member
|
Lines 139 to 141 in 0220731 Looks like Solaris CI is only ran on 8.6 or higher. cc @iluuu1994 is that intentional or an accident? |
Member
|
@jorgsowa Can you open a variant of this PR targeting 8.6 so you can test there? If it succeeds there, close that 8.6 PR and merge this one please. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Intentional, we only added Solaris recently and backporting all the fixes was not worth the hassle. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
Author
|
Modified tests are passing on 8.6: https://github.com/php/php-src/actions/runs/40120224651/job/120950008844?pr=24660 (there is still one failing test that is fixed in another PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Solaris
/proc/self/fdentries are not symlinks, so readlink() fails with EINVAL.Ref: #24410